[PR #884] [MERGED] Centralise ANSI code removal to log transforms #1178

New issue

Closed

opened 2026-10-31 22:20:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/884
Author: @webfiltered
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @webfiltered

Base: main ← Head: antsy-logging

📝 Commits (3)

c7e290e Replace ANSI code filtering with log transform
945085b [Refactor] Store relevant code together (ANSI)
b5055ea Remove double-filtering of ANSI codes

📊 Changes

6 files changed (+19 additions, -15 deletions)

View changed files

📝 src/infrastructure/structuredLogging.ts (+10 -0)
📝 src/install/installationManager.ts (+3 -3)
📝 src/main-process/comfyServer.ts (+4 -6)
📝 src/main.ts (+2 -1)
📝 src/services/sentry.ts (+0 -3)
📝 src/utils.ts (+0 -2)

📄 Description

Prepended to transforms - ANSI filtering will now run before other transforms
Simplifies code
Removes double-filtering when sentry reads the log files back into memory

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/884 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `antsy-logging` --- ### 📝 Commits (3) - [`c7e290e`](https://github.com/Comfy-Org/desktop/commit/c7e290e0adf628053ff8e92373f6d8ebebbf0fca) Replace ANSI code filtering with log transform - [`945085b`](https://github.com/Comfy-Org/desktop/commit/945085b5d78eb5629195d2938e7fe1d7767bbe3b) [Refactor] Store relevant code together (ANSI) - [`b5055ea`](https://github.com/Comfy-Org/desktop/commit/b5055ea802b054c48a6dcae4db0759f7a66c387f) Remove double-filtering of ANSI codes ### 📊 Changes **6 files changed** (+19 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/infrastructure/structuredLogging.ts` (+10 -0) 📝 `src/install/installationManager.ts` (+3 -3) 📝 `src/main-process/comfyServer.ts` (+4 -6) 📝 `src/main.ts` (+2 -1) 📝 `src/services/sentry.ts` (+0 -3) 📝 `src/utils.ts` (+0 -2) </details> ### 📄 Description - Prepended to transforms - ANSI filtering will now run before other transforms - Simplifies code - Removes double-filtering when sentry reads the log files back into memory ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-884-Centralise-ANSI-code-removal-to-log-transforms-1966d73d365081109548c5201311ef83) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:09 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:58 +00:00

[PR #1178] [MERGED] v0.4.50 #1388

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1178

No description provided.

Rows
Columns