[PR #887] [MERGED] [Dev] Improve debugging & launching #1181

New issue

Closed

opened 2026-10-31 22:20:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/887
Author: @webfiltered
Created: 2/11/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @webfiltered

Base: main ← Head: friendly-debug

📝 Commits (6)

7af46dd Allow vite build --watch without app launch
860e819 Use default frontend dev URL in env example
4341a97 Fix regression in yarn start
3fa0819 Add native vscode debugging and build watch tasks
14056dc Update README with new debugging and build info
385c25d Fix app won't start in vscode debugger

📊 Changes

7 files changed (+99 additions, -24 deletions)

View changed files

📝 .env_example (+1 -1)
📝 .vscode/launch.json (+17 -13)
📝 .vscode/tasks.json (+62 -4)
📝 README.md (+5 -3)
📝 infrastructure/viteElectronAppPlugin.ts (+6 -2)
📝 package.json (+1 -1)
📝 src/shell/terminal.ts (+7 -0)

📄 Description

Debug

Adds improved debug capability.

Standard debug keys now work as expected
Restarting the app won't force a full recompile
App rebuilding is provided by two separate vscode build tasks
Convenience build task Start Vite Build Watchers spawns both
Launch and restart run significantly faster
Add workaround for app hangs during start in vscode debugger - node-pty / ConPTY issue
- Expected to be resolved by production release of node-pty 1.1.0 (beta does not resolve)

Build

Add vite build watch & terminate tasks
yarn start now runs vite with a special build flag to retain its unique behaviour:
- Runs the app in in node.js production mode
- Watches code
- Stops app and rebuilds on change
- Restarts the app
Update README to reflect changes

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/887 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/11/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `friendly-debug` --- ### 📝 Commits (6) - [`7af46dd`](https://github.com/Comfy-Org/desktop/commit/7af46dddb9c204ae76a28280456c552fcd9c10ff) Allow vite build --watch without app launch - [`860e819`](https://github.com/Comfy-Org/desktop/commit/860e819e39ef74a7d32f6b368ddc94e1685f3bbd) Use default frontend dev URL in env example - [`4341a97`](https://github.com/Comfy-Org/desktop/commit/4341a97223607814d780d8bbe34c274fbd92eef0) Fix regression in yarn start - [`3fa0819`](https://github.com/Comfy-Org/desktop/commit/3fa08190cdb603fa1009abf11f5417fc7b0fbc95) Add native vscode debugging and build watch tasks - [`14056dc`](https://github.com/Comfy-Org/desktop/commit/14056dc76eaa46dcbc2cfc99fa6e23b99f0b8ce9) Update README with new debugging and build info - [`385c25d`](https://github.com/Comfy-Org/desktop/commit/385c25d95d0fd721768c288e5afaef0bd5bc70f2) Fix app won't start in vscode debugger ### 📊 Changes **7 files changed** (+99 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `.env_example` (+1 -1) 📝 `.vscode/launch.json` (+17 -13) 📝 `.vscode/tasks.json` (+62 -4) 📝 `README.md` (+5 -3) 📝 `infrastructure/viteElectronAppPlugin.ts` (+6 -2) 📝 `package.json` (+1 -1) 📝 `src/shell/terminal.ts` (+7 -0) </details> ### 📄 Description ### Debug Adds improved debug capability. - Standard debug keys now work as expected - Restarting the app won't force a full recompile - App rebuilding is provided by two separate vscode `build` tasks - Convenience build task `Start Vite Build Watchers` spawns both - Launch and restart run significantly faster - Add workaround for app hangs during start in vscode debugger - node-pty / ConPTY issue - Expected to be resolved by production release of node-pty 1.1.0 (beta does not resolve) ### Build - Add `vite build watch` & terminate tasks - `yarn start` now runs vite with a special build flag to retain its unique behaviour: - Runs the app in in `node.js` production mode - Watches code - Stops app and rebuilds on change - Restarts the app - Update README to reflect changes ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-887-Dev-Improve-debugging-launching-1976d73d365081bd90d2e18a298791a4) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:00 +00:00

[PR #1181] [MERGED] v0.4.51 #1389

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1181

No description provided.

Rows
Columns