[PR #902] [MERGED] Remove unnecessary nullcheck #1189

New issue

Closed

opened 2026-10-31 22:20:16 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/902
Author: @christian-byrne
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @webfiltered

Base: main ← Head: cb-nullcheck

📝 Commits (1)

4851b4b remove unnecessary nullcheck

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/install/installationManager.ts (+1 -1)

📄 Description

Removes unnecessary/misleading check -- not possible for validateHardware to return falsy value and hardware is used without nullcheck in proceeding lines.

github.com/Comfy-Org/desktop@9bf7785fe4/src/utils.ts (L140)

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/902 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `cb-nullcheck` --- ### 📝 Commits (1) - [`4851b4b`](https://github.com/Comfy-Org/desktop/commit/4851b4b5efb16faa2e15a153eb97d89ec398b9f8) remove unnecessary nullcheck ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/install/installationManager.ts` (+1 -1) </details> ### 📄 Description Removes unnecessary/misleading check -- not possible for `validateHardware` to return falsy value and `hardware` is used without nullcheck in proceeding lines. https://github.com/Comfy-Org/desktop/blob/9bf7785fe493e4e4c6e33b0475814428929d6b89/src/utils.ts#L140 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-902-Remove-unnecessary-nullcheck-19b6d73d36508139a5dbd0a04bba11c1) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:16 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1189

No description provided.

Rows
Columns