[PR #908] [MERGED] [e2e] Add test teardown #1196

New issue

Closed

opened 2026-10-31 22:20:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/908
Author: @webfiltered
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @webfiltered

Base: main ← Head: e2e-teardown

📝 Commits (5)

28dafd4 nit - Rename
81f07ac nit
8ea9c17 Add default install location shared function
737cbd1 Add teardown test project
cffd63a Add Playwright teardown project to clean post-install env

📊 Changes

5 files changed (+47 additions, -9 deletions)

View changed files

📝 playwright.config.ts (+6 -1)
📝 tests/integration/post-install.setup.ts (+5 -5)
➕ tests/integration/post-install.teardown.ts (+15 -0)
📝 tests/integration/testEnvironment.ts (+6 -1)
📝 tests/shared/utils.ts (+15 -2)

📄 Description

Add test teardown of default install dir
Cleanup

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/908 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-teardown` --- ### 📝 Commits (5) - [`28dafd4`](https://github.com/Comfy-Org/desktop/commit/28dafd414b36d9456e34bab83a9e7d1529d35a06) nit - Rename - [`81f07ac`](https://github.com/Comfy-Org/desktop/commit/81f07ac0cabe0c3dfbfb6d1ace89e02e0a1b1d0f) nit - [`8ea9c17`](https://github.com/Comfy-Org/desktop/commit/8ea9c1789925c261b1d6e33e58e62738830feb89) Add default install location shared function - [`737cbd1`](https://github.com/Comfy-Org/desktop/commit/737cbd195d980e0040828061774916d8d78f3448) Add teardown test project - [`cffd63a`](https://github.com/Comfy-Org/desktop/commit/cffd63aa8d16494ae613e8dca42f74d72943d1df) Add Playwright teardown project to clean post-install env ### 📊 Changes **5 files changed** (+47 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `playwright.config.ts` (+6 -1) 📝 `tests/integration/post-install.setup.ts` (+5 -5) ➕ `tests/integration/post-install.teardown.ts` (+15 -0) 📝 `tests/integration/testEnvironment.ts` (+6 -1) 📝 `tests/shared/utils.ts` (+15 -2) </details> ### 📄 Description - Add test teardown of default install dir - Cleanup ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-908-e2e-Add-test-teardown-19b6d73d36508124b008cdcf1a5cd304) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:19 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1196

No description provided.

Rows
Columns