[PR #909] [MERGED] [Dev] Finalise developer exp. improvements for e2e testing #1197

New issue

Closed

opened 2026-10-31 22:20:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/909
Author: @webfiltered
Created: 2/15/2025
Status: ✅ Merged
Merged: 2/15/2025
Merged by: @webfiltered

Base: main ← Head: e2e-volatile-tests

📝 Commits (6)

7dbe40e Add cursor rules for e2e testing
54fa8dd [DevExp] Disable local volatile testing by default
4f82eab [Debug] Add Playwright reporters
46b5c44 [Debug] Record all traces
e5744bd Revert "[Debug] Record all traces"
63e91dd Fix Playwright setup project hoisting

📊 Changes

8 files changed (+68 additions, -3 deletions)

View changed files

➕ .cursor/rules/playwright.mdc (+30 -0)
➕ .env.test_example (+11 -0)
📝 playwright.config.ts (+2 -1)
📝 playwright.setup.ts (+4 -1)
📝 tests/README.md (+7 -0)
📝 tests/integration/post-install.teardown.ts (+3 -1)
📝 tests/integration/testEnvironment.ts (+4 -0)
📝 tests/integration/testExtensions.ts (+7 -0)

📄 Description

Adds cursor rules
Disables Playwright tests by default; can be enabled via env var

Local test execution

If testing via the vscode extension or running tests individually, attempting to run tests from the post-install project may trigger all tests in the install project ro run first.

Workaround: disable all other projects to ensure the CI setup/teardown execution is skipped.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/909 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/15/2025 **Status:** ✅ Merged **Merged:** 2/15/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-volatile-tests` --- ### 📝 Commits (6) - [`7dbe40e`](https://github.com/Comfy-Org/desktop/commit/7dbe40e1ed6d23a56a69a4fe5aac049a46157713) Add cursor rules for e2e testing - [`54fa8dd`](https://github.com/Comfy-Org/desktop/commit/54fa8dd087c6c0a85797602fbeb07f1cb712ff17) [DevExp] Disable local volatile testing by default - [`4f82eab`](https://github.com/Comfy-Org/desktop/commit/4f82eab08d56ccc4ab2743966a5fac973aafb3c2) [Debug] Add Playwright reporters - [`46b5c44`](https://github.com/Comfy-Org/desktop/commit/46b5c44aa3d74e4dae262a5999edd3a4e5e40deb) [Debug] Record all traces - [`e5744bd`](https://github.com/Comfy-Org/desktop/commit/e5744bd1ec158f2e52e6adc61da2b69950e70f4a) Revert "[Debug] Record all traces" - [`63e91dd`](https://github.com/Comfy-Org/desktop/commit/63e91ddc6aea0de020401a4927d4992abe5e67ec) Fix Playwright setup project hoisting ### 📊 Changes **8 files changed** (+68 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `.cursor/rules/playwright.mdc` (+30 -0) ➕ `.env.test_example` (+11 -0) 📝 `playwright.config.ts` (+2 -1) 📝 `playwright.setup.ts` (+4 -1) 📝 `tests/README.md` (+7 -0) 📝 `tests/integration/post-install.teardown.ts` (+3 -1) 📝 `tests/integration/testEnvironment.ts` (+4 -0) 📝 `tests/integration/testExtensions.ts` (+7 -0) </details> ### 📄 Description - Adds cursor rules - Disables Playwright tests by default; can be enabled via env var #### Local test execution If testing via the vscode extension or running tests individually, attempting to run tests from the `post-install` project may trigger all tests in the `install` project ro run first. Workaround: disable all other projects to ensure the CI setup/teardown execution is skipped. ![image](https://github.com/user-attachments/assets/42f22266-2b2a-4dcd-8c8a-1a499316f1b8) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-909-Dev-Finalise-developer-exp-improvements-for-e2e-testing-19b6d73d36508159bc1ff0eedd455da0) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:19 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:03 +00:00

[PR #1197] [MERGED] [CI] Improve Claude Code command for version bump #1397

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1197

No description provided.

Rows
Columns