[PR #912] [MERGED] Use upstream Manager. #1199

Closed
opened 2026-10-31 22:20:21 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/912
Author: @robinjhuang
Created: 2/16/2025
Status: ✅ Merged
Merged: 3/1/2025
Merged by: @robinjhuang

Base: main ← Head: rh-manager-new


📝 Commits (10+)

📊 Changes

6 files changed (+36 additions, -11 deletions)

View changed files

📝 assets/requirements/windows_cpu.compiled (+3 -0)
📝 assets/requirements/windows_nvidia.compiled (+3 -0)
📝 package.json (+1 -1)
📝 scripts/makeComfy.js (+1 -1)
📝 src/services/cmCli.ts (+24 -8)
📝 src/virtualEnvironment.ts (+4 -1)

📄 Description

  • Includes bug fixes from manager:
    github.com/ltdrdata/ComfyUI-Manager@488f023bdf
  • Fixed: migrating custom nodes: uses restore-to to fix importing custom nodes.
  • Remove extra ComfyUI-Manager when migrating/importing from another ComfyUI install
  • Updated requirements.compiled

┆Issue is synchronized with this Notion page by Unito


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/912 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 2/16/2025 **Status:** ✅ Merged **Merged:** 3/1/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-manager-new` --- ### 📝 Commits (10+) - [`0f3e1b7`](https://github.com/Comfy-Org/desktop/commit/0f3e1b77745c9b140669d357361f5bbe7035e829) Pass comfyui path. - [`7713ca2`](https://github.com/Comfy-Org/desktop/commit/7713ca2383ddcd0bdff44a8064a64f6b8ad76f7b) Use upstream Manager. - [`681bc6c`](https://github.com/Comfy-Org/desktop/commit/681bc6c002fbf2262d43b2f08816e10b390b6052) Add user directory argument. - [`0658e11`](https://github.com/Comfy-Org/desktop/commit/0658e11ba0d7bfb510eee4875086c3fb5d5a98e1) Install new dependency chardet. - [`f12fd50`](https://github.com/Comfy-Org/desktop/commit/f12fd50b3b17af9a8d8de100d5f523a2cafe3f5a) Use new restore-to argument. - [`250d7f5`](https://github.com/Comfy-Org/desktop/commit/250d7f5acd1ec0c9ea4f958851f8dd1cfe18b75a) Fix restore to path. - [`1b7a7e9`](https://github.com/Comfy-Org/desktop/commit/1b7a7e9997b55aac9567ec5b1a22725e6dd2e922) Remove ComfyUI-Manager from migration. - [`c61b85a`](https://github.com/Comfy-Org/desktop/commit/c61b85aa0633aef3be4c552d66476fde3f2204f2) Update to latest manager. - [`bfb70c6`](https://github.com/Comfy-Org/desktop/commit/bfb70c6ade8f7f7a04ad39add3d07066bf8aa013) Revert. - [`a8ffa61`](https://github.com/Comfy-Org/desktop/commit/a8ffa61b70019469b1d3045de4bd66c3d5958b6d) Update compiled requirements. ### 📊 Changes **6 files changed** (+36 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `assets/requirements/windows_cpu.compiled` (+3 -0) 📝 `assets/requirements/windows_nvidia.compiled` (+3 -0) 📝 `package.json` (+1 -1) 📝 `scripts/makeComfy.js` (+1 -1) 📝 `src/services/cmCli.ts` (+24 -8) 📝 `src/virtualEnvironment.ts` (+4 -1) </details> ### 📄 Description - Includes bug fixes from manager: https://github.com/ltdrdata/ComfyUI-Manager/commit/488f023bdf49d6b85a00e230501eb009f5ffdbd9 - Fixed: migrating custom nodes: uses `restore-to` to fix importing custom nodes. - Remove extra ComfyUI-Manager when migrating/importing from another ComfyUI install - Updated requirements.compiled ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-912-Use-upstream-Manager-19c6d73d365081fe9711f9baf8bb81b6) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:20:21 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#1199
No description provided.