[PR #913] [MERGED] [e2e] Add maintenance page tests #1200

New issue

Closed

opened 2026-10-31 22:20:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/913
Author: @webfiltered
Created: 2/16/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @webfiltered

Base: main ← Head: e2e-maintenance

📝 Commits (7)

a103ebb Add troubleshooting page tests
80322e8 Fix e2e screenshot issue - window maximised during install
5fbb094 Fix log names never match file names
8546a7d Add test: fix base path
c69a965 nit
fbb1f2e Revert "nit"
8904051 nit

📊 Changes

9 files changed (+159 additions, -7 deletions)

View changed files

📝 tests/integration/post-install.setup.ts (+4 -1)
➕ tests/integration/post-install/troubleshooting.spec.ts (+53 -0)
➕ tests/integration/post-install/troubleshooting.spec.ts-snapshots/troubleshooting-base-path-post-install-win32.png (+0 -0)
➕ tests/integration/post-install/troubleshooting.spec.ts-snapshots/troubleshooting-post-install-win32.png (+0 -0)
📝 tests/integration/testApp.ts (+16 -2)
📝 tests/integration/testEnvironment.ts (+22 -1)
📝 tests/integration/testExtensions.ts (+11 -3)
➕ tests/integration/testTaskCard.ts (+18 -0)
➕ tests/integration/testTroubleshooting.ts (+35 -0)

📄 Description

Repairs invalid base path issue and confirms app load.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/913 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/16/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-maintenance` --- ### 📝 Commits (7) - [`a103ebb`](https://github.com/Comfy-Org/desktop/commit/a103ebb18959128aca6e811bb2657a32afcbeacb) Add troubleshooting page tests - [`80322e8`](https://github.com/Comfy-Org/desktop/commit/80322e828d048b0141b8626a684b8c3235e90bb5) Fix e2e screenshot issue - window maximised during install - [`5fbb094`](https://github.com/Comfy-Org/desktop/commit/5fbb09477ea37ead7c9d593cc6601a001c6b7049) Fix log names never match file names - [`8546a7d`](https://github.com/Comfy-Org/desktop/commit/8546a7d4c736ecc591bf285b2bd54aca2de0ac58) Add test: fix base path - [`c69a965`](https://github.com/Comfy-Org/desktop/commit/c69a9650f018fa7158de034d4d0a28e76e9f7dbe) nit - [`fbb1f2e`](https://github.com/Comfy-Org/desktop/commit/fbb1f2eeefb3b68dcca0df854df1f5bc6fbed734) Revert "nit" - [`8904051`](https://github.com/Comfy-Org/desktop/commit/8904051936977ed63af51d262e68134850d598da) nit ### 📊 Changes **9 files changed** (+159 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/post-install.setup.ts` (+4 -1) ➕ `tests/integration/post-install/troubleshooting.spec.ts` (+53 -0) ➕ `tests/integration/post-install/troubleshooting.spec.ts-snapshots/troubleshooting-base-path-post-install-win32.png` (+0 -0) ➕ `tests/integration/post-install/troubleshooting.spec.ts-snapshots/troubleshooting-post-install-win32.png` (+0 -0) 📝 `tests/integration/testApp.ts` (+16 -2) 📝 `tests/integration/testEnvironment.ts` (+22 -1) 📝 `tests/integration/testExtensions.ts` (+11 -3) ➕ `tests/integration/testTaskCard.ts` (+18 -0) ➕ `tests/integration/testTroubleshooting.ts` (+35 -0) </details> ### 📄 Description Repairs invalid base path issue and confirms app load. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-913-e2e-Add-maintenance-page-tests-19c6d73d36508134834ef20d80e9da1c) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:22 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:05 +00:00

[PR #1200] [MERGED] [CI] Improve version update PR details #1401

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1200

No description provided.

Rows
Columns