[PR #914] [MERGED] [e2e] Add recreate virtual environment test #1201

New issue

Closed

opened 2026-10-31 22:20:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/914
Author: @webfiltered
Created: 2/16/2025
Status: ✅ Merged
Merged: 2/16/2025
Merged by: @webfiltered

Base: main ← Head: e2e-venv-troubleshooting

📝 Commits (9)

bacb77c nit - Rename
64cfdd9 [e2e] Add recreate virtual environment test
2c093f2 Add test expectation
0c34447 Fix button name
7a42e0f Replace manual test env cleanup with disposable
aff76ab [Dev] Fix vscode debug + playwright ext. conflict
06a893c Fix venv creation - use confirm buttons & wait for server start
0eeac00 Fix server start timeout too short
d546af5 Fix new disposable clean up never runs

📊 Changes

10 files changed (+98 additions, -17 deletions)

View changed files

📝 tests/integration/post-install/troubleshooting.spec.ts (+2 -10)
➕ tests/integration/post-install/troubleshooting.spec.ts-snapshots/troubleshooting-venv-post-install-win32.png (+0 -0)
➕ tests/integration/post-install/troubleshootingVenv.spec.ts (+33 -0)
➕ tests/integration/post-install/troubleshootingVenv.spec.ts-snapshots/troubleshooting-venv-post-install-win32.png (+0 -0)
📝 tests/integration/testApp.ts (+2 -0)
📝 tests/integration/testEnvironment.ts (+39 -3)
📝 tests/integration/testInstalledApp.ts (+1 -1)
📝 tests/integration/testServerStart.ts (+10 -0)
📝 tests/integration/testTaskCard.ts (+2 -2)
📝 tests/integration/testTroubleshooting.ts (+9 -1)

📄 Description

Replace manual test env cleanup with disposable

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/914 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/16/2025 **Status:** ✅ Merged **Merged:** 2/16/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-venv-troubleshooting` --- ### 📝 Commits (9) - [`bacb77c`](https://github.com/Comfy-Org/desktop/commit/bacb77ce89f3161ce9591bdf3b26cc36e4607d44) nit - Rename - [`64cfdd9`](https://github.com/Comfy-Org/desktop/commit/64cfdd9b99b7e32faff771524cc91e4cbd05078d) [e2e] Add recreate virtual environment test - [`2c093f2`](https://github.com/Comfy-Org/desktop/commit/2c093f2ba5a7066672c76f1e0c7f61185edb909a) Add test expectation - [`0c34447`](https://github.com/Comfy-Org/desktop/commit/0c344477f858426be6eaaf9af5d9e984b294e2ef) Fix button name - [`7a42e0f`](https://github.com/Comfy-Org/desktop/commit/7a42e0fba60a9fae27bab3c10e30908b41d5a5be) Replace manual test env cleanup with disposable - [`aff76ab`](https://github.com/Comfy-Org/desktop/commit/aff76ab6619a10e7f3edeb4bcf432e08f03d92bd) [Dev] Fix vscode debug + playwright ext. conflict - [`06a893c`](https://github.com/Comfy-Org/desktop/commit/06a893c64d3080b436063d02519ca2a89267d740) Fix venv creation - use confirm buttons & wait for server start - [`0eeac00`](https://github.com/Comfy-Org/desktop/commit/0eeac004743c07f0067c33d0f1875f7a5eb2ddcb) Fix server start timeout too short - [`d546af5`](https://github.com/Comfy-Org/desktop/commit/d546af5a41a17f878cbef4a4bb39e9ea7254301b) Fix new disposable clean up never runs ### 📊 Changes **10 files changed** (+98 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/post-install/troubleshooting.spec.ts` (+2 -10) ➕ `tests/integration/post-install/troubleshooting.spec.ts-snapshots/troubleshooting-venv-post-install-win32.png` (+0 -0) ➕ `tests/integration/post-install/troubleshootingVenv.spec.ts` (+33 -0) ➕ `tests/integration/post-install/troubleshootingVenv.spec.ts-snapshots/troubleshooting-venv-post-install-win32.png` (+0 -0) 📝 `tests/integration/testApp.ts` (+2 -0) 📝 `tests/integration/testEnvironment.ts` (+39 -3) 📝 `tests/integration/testInstalledApp.ts` (+1 -1) 📝 `tests/integration/testServerStart.ts` (+10 -0) 📝 `tests/integration/testTaskCard.ts` (+2 -2) 📝 `tests/integration/testTroubleshooting.ts` (+9 -1) </details> ### 📄 Description Replace manual test env cleanup with disposable ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-914-e2e-Add-recreate-virtual-environment-test-19c6d73d36508168bc02ef16929569f6) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:22 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:05 +00:00

[PR #1201] [MERGED] v0.4.52 #1399

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1201

No description provided.

Rows
Columns