[PR #936] [MERGED] Improve ComfyServer process management & logging #1220

New issue

Closed

opened 2026-10-31 22:20:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/936
Author: @webfiltered
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @webfiltered

Base: main ← Head: cleanup-comfy-server

📝 Commits (7)

1277e9f Remove "Failed to start" listener once started
1c7689c Add current running state to ComfyServer
5955292 Remove redundant logging
7f3daaa Guard against running multiple servers
9dbfdfd Doc
6c63044 nit
7c30d1f [Cleanup] Remove redundant code

📊 Changes

1 file changed (+33 additions, -6 deletions)

View changed files

📝 src/main-process/comfyServer.ts (+33 -6)

📄 Description

Adds check for current server state
Removes erroneous log entry on 'error'
Removes redundant logging
Guards against attempt to run multiple server instances

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/936 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `cleanup-comfy-server` --- ### 📝 Commits (7) - [`1277e9f`](https://github.com/Comfy-Org/desktop/commit/1277e9f1d46ee761f412e795978ca321f5ed540b) Remove "Failed to start" listener once started - [`1c7689c`](https://github.com/Comfy-Org/desktop/commit/1c7689c9b99c47776080f9719018f85bc6034c38) Add current running state to ComfyServer - [`5955292`](https://github.com/Comfy-Org/desktop/commit/5955292eb59d7aabd4a4d36f121b5ed8379c1e38) Remove redundant logging - [`7f3daaa`](https://github.com/Comfy-Org/desktop/commit/7f3daaaadaf55876bd6f72d6b782a14e0c2af606) Guard against running multiple servers - [`9dbfdfd`](https://github.com/Comfy-Org/desktop/commit/9dbfdfda3f20789ee171a8a199496e91c5f17f84) Doc - [`6c63044`](https://github.com/Comfy-Org/desktop/commit/6c630440ec42c598f67417af2cfe74f99b85d897) nit - [`7c30d1f`](https://github.com/Comfy-Org/desktop/commit/7c30d1f1132a6631f1e6856560481460c9e45d72) [Cleanup] Remove redundant code ### 📊 Changes **1 file changed** (+33 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/comfyServer.ts` (+33 -6) </details> ### 📄 Description - Adds check for current server state - Removes erroneous log entry on `'error'` - Removes redundant logging - Guards against attempt to run multiple server instances ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-936-Improve-ComfyServer-process-management-logging-19e6d73d36508174b178ec351d698130) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:33 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1220

No description provided.

Rows
Columns