[PR #944] [MERGED] [CodeHealth] Type updates & simplifications #1226

Closed
opened 2026-10-31 22:20:36 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/944
Author: @webfiltered
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/18/2025
Merged by: @webfiltered

Base: main ← Head: j-b-o-n


📝 Commits (5)

📊 Changes

5 files changed (+23 additions, -31 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 src/desktopApp.ts (+1 -1)
📝 src/install/installationManager.ts (+13 -13)
📝 src/install/troubleshooting.ts (+4 -7)
📝 src/shell/terminal.ts (+4 -9)

📄 Description

Collection of minor changes and simplifications.

┆Issue is synchronized with this Notion page by Unito


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/944 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/18/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `j-b-o-n` --- ### 📝 Commits (5) - [`c419ec2`](https://github.com/Comfy-Org/desktop/commit/c419ec2590fdb5730d52ec95e219d728a07fd9c5) nit - [`a470eba`](https://github.com/Comfy-Org/desktop/commit/a470ebafcf5238a3619464457ce7b3bb48d5a261) Remove redundant code - [`479a7e6`](https://github.com/Comfy-Org/desktop/commit/479a7e64ae071926d1b2ea1b1e1954546516b6d0) nit - [`9cd560b`](https://github.com/Comfy-Org/desktop/commit/9cd560be21bde2d0f740709f0eef5c38d192af66) nit - [`fbf75df`](https://github.com/Comfy-Org/desktop/commit/fbf75dfd402a14fd42acba571c48c218b493ea7d) nit ### 📊 Changes **5 files changed** (+23 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `src/desktopApp.ts` (+1 -1) 📝 `src/install/installationManager.ts` (+13 -13) 📝 `src/install/troubleshooting.ts` (+4 -7) 📝 `src/shell/terminal.ts` (+4 -9) </details> ### 📄 Description Collection of minor changes and simplifications. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-944-CodeHealth-Type-updates-simplifications-19e6d73d365081d385fdd8a7a64ce57d) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:20:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#1226
No description provided.