[PR #1004] [MERGED] [e2e] Ignore desktop version in screenshot validation #1278

New issue

Closed

opened 2026-10-31 22:21:02 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:02 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1004
Author: @webfiltered
Created: 2/27/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @webfiltered

Base: main ← Head: e2e-ignore-version

📝 Commits (1)

595372e [e2e] Ignore desktop version in screenshot validation

📊 Changes

3 files changed (+7 additions, -1 deletions)

View changed files

📝 tests/integration/post-install/troubleshootingServerStart.spec.ts (+3 -1)
📝 tests/integration/post-install/troubleshootingServerStart.spec.ts-snapshots/cannot-start-server-troubleshoot-post-install-win32.png (+0 -0)
📝 tests/integration/testServerStatus.ts (+4 -0)

📄 Description

Removes requirement to update test expectation every version bump.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1004 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/27/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-ignore-version` --- ### 📝 Commits (1) - [`595372e`](https://github.com/Comfy-Org/desktop/commit/595372e9467f7c256313c789bd368714538908e2) [e2e] Ignore desktop version in screenshot validation ### 📊 Changes **3 files changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/post-install/troubleshootingServerStart.spec.ts` (+3 -1) 📝 `tests/integration/post-install/troubleshootingServerStart.spec.ts-snapshots/cannot-start-server-troubleshoot-post-install-win32.png` (+0 -0) 📝 `tests/integration/testServerStatus.ts` (+4 -0) </details> ### 📄 Description - Removes requirement to update test expectation every version bump. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1004-e2e-Ignore-desktop-version-in-screenshot-validation-1a76d73d365081b789e8c66c52088b45) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:02 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:27 +00:00

[PR #1278] [CI] Add automatic release generating GitHub Action #1453

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1278

No description provided.

Rows
Columns