[PR #1042] [MERGED] [CI] Update build patcher - throw on fail, extensible #1301

New issue

Closed

opened 2026-10-31 22:21:15 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1042
Author: @webfiltered
Created: 3/10/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @webfiltered

Base: main ← Head: throw-if-patch-fails

📝 Commits (4)

04ca0e9 [CI] Ensure patch step runs in all builds
c138834 [CI] Ensure build fails when core patch fails
324f294 [CI] Improve patch script - now extensible
244aeb3 [CI] Remove redundant build step

📊 Changes

5 files changed (+65 additions, -13 deletions)

View changed files

📝 .github/actions/build/macos/comfy/action.yml (+0 -1)
📝 .github/actions/build/windows/app/action.yml (+0 -1)
📝 package.json (+1 -1)
📝 scripts/makeComfy.js (+1 -0)
📝 scripts/patchComfyUI.js (+63 -10)

📄 Description

Patch step runs outside CI
Build fails when core patch fails
Improve patch script - allows generic patching

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1042 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `throw-if-patch-fails` --- ### 📝 Commits (4) - [`04ca0e9`](https://github.com/Comfy-Org/desktop/commit/04ca0e9c055cca3d4bc37b85a85037d04089e730) [CI] Ensure patch step runs in all builds - [`c138834`](https://github.com/Comfy-Org/desktop/commit/c13883495d10b11d6096356a6dc18c767310774d) [CI] Ensure build fails when core patch fails - [`324f294`](https://github.com/Comfy-Org/desktop/commit/324f294e4510db1e08b01b787e58fb98f003889e) [CI] Improve patch script - now extensible - [`244aeb3`](https://github.com/Comfy-Org/desktop/commit/244aeb342752d6f9d7e3ab61435b3620affc5776) [CI] Remove redundant build step ### 📊 Changes **5 files changed** (+65 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/macos/comfy/action.yml` (+0 -1) 📝 `.github/actions/build/windows/app/action.yml` (+0 -1) 📝 `package.json` (+1 -1) 📝 `scripts/makeComfy.js` (+1 -0) 📝 `scripts/patchComfyUI.js` (+63 -10) </details> ### 📄 Description - Patch step runs outside CI - Build fails when core patch fails - Improve patch script - allows generic patching ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1042-CI-Update-build-patcher-throw-on-fail-extensible-1b26d73d365081159082f6274c424b11) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:15 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:37 +00:00

[PR #1301] [MERGED] Add integration testing documentation #1473

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1301

No description provided.

Rows
Columns