[PR #1103] [MERGED] Allow options to be passed to checkForUpdates #1341

New issue

Closed

opened 2026-10-31 22:21:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1103
Author: @benceruleanlu
Created: 4/20/2025
Status: ✅ Merged
Merged: 4/20/2025
Merged by: @benceruleanlu

Base: main ← Head: lobotomy

📝 Commits (1)

dc02317 Allow options to be passed to checkForUpdates

📊 Changes

2 files changed (+5 additions, -4 deletions)

View changed files

📝 package.json (+1 -1)
📝 src/preload.ts (+4 -3)

📄 Description

Used to prevent todesktop from handling the update prompts since frontend already has a confirm dialog to prompt restart and install.

sorry about the pr/npm spam 😖

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1103 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 4/20/2025 **Status:** ✅ Merged **Merged:** 4/20/2025 **Merged by:** [@benceruleanlu](https://github.com/benceruleanlu) **Base:** `main` ← **Head:** `lobotomy` --- ### 📝 Commits (1) - [`dc02317`](https://github.com/Comfy-Org/desktop/commit/dc02317ce5e53bcfa9425f01afa9606886af301b) Allow options to be passed to checkForUpdates ### 📊 Changes **2 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -1) 📝 `src/preload.ts` (+4 -3) </details> ### 📄 Description Used to prevent todesktop from handling the update prompts since frontend already has a confirm dialog to prompt restart and install. sorry about the pr/npm spam 😖 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1103-Allow-options-to-be-passed-to-checkForUpdates-1db6d73d365081f28c1ff0ba21ca477c) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:35 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1341

No description provided.

Rows
Columns