[PR #1171] [MERGED] Fix `rejects Windows with AMD GPU` unit test #1385

New issue

Closed

opened 2026-10-31 22:21:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1171
Author: @benceruleanlu
Created: 5/18/2025
Status: ✅ Merged
Merged: 5/18/2025
Merged by: @webfiltered

Base: main ← Head: bl-utils-nvidia-windows-test-fix

📝 Commits (1)

81781a8 Fix utils unit test on win/nv

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 tests/unit/utils.test.ts (+11 -0)

📄 Description

The rejects Windows with AMD GPU unit test fails on a Windows/Nvidia machine because we only mocked si.graphics, but the code has a fallback to check with nvidia-smi.

This PR suggests mocking both execAsync processes to fail, better simulating what would happen if a user had an AMD gpu on a Windows machine.

github.com/Comfy-Org/desktop@df5ae706e7/src/utils.ts (L160-L189)

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1171 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 5/18/2025 **Status:** ✅ Merged **Merged:** 5/18/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `bl-utils-nvidia-windows-test-fix` --- ### 📝 Commits (1) - [`81781a8`](https://github.com/Comfy-Org/desktop/commit/81781a88335034d1228e86a96d1f608cb34a2cd6) Fix utils unit test on win/nv ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/utils.test.ts` (+11 -0) </details> ### 📄 Description The `rejects Windows with AMD GPU` unit test fails on a Windows/Nvidia machine because we only mocked `si.graphics`, but the code has a fallback to check with `nvidia-smi`. This PR suggests mocking both execAsync processes to fail, better simulating what would happen if a user had an AMD gpu on a Windows machine. https://github.com/Comfy-Org/desktop/blob/df5ae706e7f914a7bb6ccc7ab50a5abebf7170de/src/utils.ts#L160-L189 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1171-Fix-rejects-Windows-with-AMD-GPU-unit-test-1f76d73d3650818f8f24e7146105754b) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:58 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1385

No description provided.

Rows
Columns

[PR #1171] [MERGED] Fix rejects Windows with AMD GPU unit test #1385

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #1171] [MERGED] Fix `rejects Windows with AMD GPU` unit test #1385