[PR #1208] [MERGED] Add workflow for playwright test expectation #1404

New issue

Closed

opened 2026-10-31 22:22:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:22:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1208
Author: @Myestery
Created: 6/22/2025
Status: ✅ Merged
Merged: 6/25/2025
Merged by: @christian-byrne

Base: main ← Head: main

📝 Commits (7)

f9a53d0 CI workflow for Update Test Expectations
d70d1ba fix style
850a56a Add continue-on-error to Playwright Tests step
4c97d1f Fix workflow to correctly add test-results and comment out display resolution step
e52c02c Refactor update_test_expectations workflow: streamline artifact uploads and ensure consistent naming for test results
0b95662 Remove unnecessary whitespace in update_test_expectations workflow
9e595d8 use update command for playwright tests

📊 Changes

1 file changed (+54 additions, -0 deletions)

View changed files

➕ .github/workflows/update_test_expectations.yml (+54 -0)

📄 Description

fix https://github.com/Comfy-Org/desktop/issues/1179

┆Issue is synchronized with this Notion page by Unito

Requires label New Browser Test Expectations
See sample run here https://github.com/Myestery/comfy-ui-desktop/pull/2

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1208 **Author:** [@Myestery](https://github.com/Myestery) **Created:** 6/22/2025 **Status:** ✅ Merged **Merged:** 6/25/2025 **Merged by:** [@christian-byrne](https://github.com/christian-byrne) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (7) - [`f9a53d0`](https://github.com/Comfy-Org/desktop/commit/f9a53d0e388104af52d690675c9deba078f390f2) CI workflow for Update Test Expectations - [`d70d1ba`](https://github.com/Comfy-Org/desktop/commit/d70d1bab6d8ab9bd4d3acc4f2b596a96f2a301ec) fix style - [`850a56a`](https://github.com/Comfy-Org/desktop/commit/850a56a9d7ec6680dd983b091570d750e55ee6eb) Add continue-on-error to Playwright Tests step - [`4c97d1f`](https://github.com/Comfy-Org/desktop/commit/4c97d1fb7a343e462b42e741a46cdf3c9f050ebd) Fix workflow to correctly add test-results and comment out display resolution step - [`e52c02c`](https://github.com/Comfy-Org/desktop/commit/e52c02c2f41e96cd12025ef645f83598e595c4b8) Refactor update_test_expectations workflow: streamline artifact uploads and ensure consistent naming for test results - [`0b95662`](https://github.com/Comfy-Org/desktop/commit/0b956627750dd1b67e21bf5974c61425d214755f) Remove unnecessary whitespace in update_test_expectations workflow - [`9e595d8`](https://github.com/Comfy-Org/desktop/commit/9e595d8fd8d14ff7009de761821168812fa37ecd) use update command for playwright tests ### 📊 Changes **1 file changed** (+54 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/update_test_expectations.yml` (+54 -0) </details> ### 📄 Description fix https://github.com/Comfy-Org/desktop/issues/1179 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1208-Add-workflow-for-playwright-test-expectation-21a6d73d365081a4bb32f52737043a2e) by [Unito](https://www.unito.io) Requires label `New Browser Test Expectations` See sample run here https://github.com/Myestery/comfy-ui-desktop/pull/2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:22:08 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1404

No description provided.

Rows
Columns