mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[PR #1206] [CLOSED] Hide ComfyUI instead of quitting when window is closed #1406
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#1406
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/desktop/pull/1206
Author: @crowecawcaw
Created: 6/22/2025
Status: ❌ Closed
Base:
main← Head:minimize📝 Commits (7)
482c7d9Hide ComfyUI instead of quitting when window is closedddc55a6Merge branch 'main' into minimizeca17463Merge branch 'main' into minimize90af9c4Put close-to-background behind a new settingb09cf6fApply suggestions from code reviewcd0cae3Apply suggestions from code review99ecd76Clean up unit tests📊 Changes
4 files changed (+192 additions, -16 deletions)
View changed files
📝
src/main-process/appWindow.ts(+37 -12)📝
src/main.ts(+19 -4)📝
tests/unit/config/comfySettings.test.ts(+1 -0)📝
tests/unit/main-process/appWindow.test.ts(+135 -0)📄 Description
This change makes it more intuitive to keep ComfyUI running in the background. Previously, if the ComfyUI window was closed, the app quit. With this change, closing the window keeps ComfyUI running, and the window can be restored from the "Show Comfy Window" taskbar option. On a Mac, when the window is closed, the dock icon is also hidden.
Tested on Mac and Windows.
┆Issue is synchronized with this Notion page by Unito
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.