[PR #1289] [MERGED] Add install stage tracking API #1464

New issue

Closed

opened 2026-10-31 22:22:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:22:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1289
Author: @webfiltered
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @webfiltered

Base: main ← Head: api-install-progress

📝 Commits (10+)

7c55a37 Add InstallStage constants
0ff0c9f Add IPC channels for install stage tracking
5e1f997 Create InstallStageType type definition
7474be7 Add InstallStageInfo interface
27bb146 Add createInstallStageInfo helper function
e88a28b Add getInstallStageName helper function
84dd294 Export InstallStageInfo and InstallStageType types
377cb1c Import InstallStageInfo type in preload
6887376 Add InstallStage.getCurrent method to preload API
b29a8ef Add InstallStage.onUpdate method to preload API

📊 Changes

9 files changed (+206 additions, -7 deletions)

View changed files

📝 src/constants.ts (+40 -0)
📝 src/desktopApp.ts (+2 -0)
➕ src/handlers/installStateHandlers.ts (+21 -0)
📝 src/main-process/appState.ts (+14 -0)
➕ src/main-process/installStages.ts (+69 -0)
📝 src/main_types.ts (+1 -0)
📝 src/preload.ts (+30 -0)
📝 tests/unit/desktopApp.test.ts (+23 -2)
📝 vite.preload.config.ts (+6 -5)

📄 Description

Adds installation stage tracking API allowing frontend to be stateless.

Tracks app startup and install progress in main process
Broadcasts stage updates to all windows via IPC
Provides getCurrent() and onUpdate() methods removing a race condition & ensuring separation of concerns

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1289 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `api-install-progress` --- ### 📝 Commits (10+) - [`7c55a37`](https://github.com/Comfy-Org/desktop/commit/7c55a37c06241f05262fa33d4adb22f606fdb004) Add InstallStage constants - [`0ff0c9f`](https://github.com/Comfy-Org/desktop/commit/0ff0c9f5066722fd32869f41b9fafd6bf44f521c) Add IPC channels for install stage tracking - [`5e1f997`](https://github.com/Comfy-Org/desktop/commit/5e1f997de4d63f6504046fd718f35242f63489fc) Create InstallStageType type definition - [`7474be7`](https://github.com/Comfy-Org/desktop/commit/7474be7a302bdafc559d7645ebac864bae380799) Add InstallStageInfo interface - [`27bb146`](https://github.com/Comfy-Org/desktop/commit/27bb14649cccc48a78ecba3963f4b86d4cafac06) Add createInstallStageInfo helper function - [`e88a28b`](https://github.com/Comfy-Org/desktop/commit/e88a28bbf5722d86c37c3f3fd3af4fc2945aa03d) Add getInstallStageName helper function - [`84dd294`](https://github.com/Comfy-Org/desktop/commit/84dd2942bc7368aac7b783cf38cd01c5f4e299b9) Export InstallStageInfo and InstallStageType types - [`377cb1c`](https://github.com/Comfy-Org/desktop/commit/377cb1ccc52bfad7b95bfab94e305791bc1f8a5a) Import InstallStageInfo type in preload - [`6887376`](https://github.com/Comfy-Org/desktop/commit/6887376e3dfe9c99a9b0e29e64a2f511a1eb3fc4) Add InstallStage.getCurrent method to preload API - [`b29a8ef`](https://github.com/Comfy-Org/desktop/commit/b29a8efbedabd8534a49936f0ca16b9e2479de83) Add InstallStage.onUpdate method to preload API ### 📊 Changes **9 files changed** (+206 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+40 -0) 📝 `src/desktopApp.ts` (+2 -0) ➕ `src/handlers/installStateHandlers.ts` (+21 -0) 📝 `src/main-process/appState.ts` (+14 -0) ➕ `src/main-process/installStages.ts` (+69 -0) 📝 `src/main_types.ts` (+1 -0) 📝 `src/preload.ts` (+30 -0) 📝 `tests/unit/desktopApp.test.ts` (+23 -2) 📝 `vite.preload.config.ts` (+6 -5) </details> ### 📄 Description Adds installation stage tracking API allowing frontend to be stateless. - Tracks app startup and install progress in main process - Broadcasts stage updates to all windows via IPC - Provides `getCurrent()` and `onUpdate()` methods removing a race condition & ensuring separation of concerns ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1289-Add-install-stage-tracking-API-2636d73d365081f3a8aee9fb0264c2fe) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:22:33 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1464

No description provided.

Rows
Columns