[PR #1295] [MERGED] [API] Add more granular install stages #1470

Closed
opened 2026-10-31 22:22:36 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1295
Author: @webfiltered
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @webfiltered

Base: main ← Head: api-rename-clarity


📝 Commits (6)

  • 1af87a8 nit - Rename for clarity
  • f6307cd Update test expectation - this is being removed.
  • 0c169af Remove redundant code
  • 426340b Remove validation stages from InstallStage enum
  • 1cfbaee Add pytorch, ComfyUI and Manager install stages
  • 8c1b9af Revert "Update test expectation - this is being removed."

📊 Changes

3 files changed (+9 additions, -48 deletions)

View changed files

📝 src/constants.ts (+3 -10)
📝 src/main-process/installStages.ts (+5 -37)
📝 src/main_types.ts (+1 -1)

📄 Description

  • Adds individual python package stages for pytorch, core, and manager.
  • Renames misleading InstallStageType => InstallStageName.
  • Removes redundant workaround.

┆Issue is synchronized with this Notion page by Unito


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1295 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `api-rename-clarity` --- ### 📝 Commits (6) - [`1af87a8`](https://github.com/Comfy-Org/desktop/commit/1af87a83c5c645c590a6dbec4c83955c3cc69245) nit - Rename for clarity - [`f6307cd`](https://github.com/Comfy-Org/desktop/commit/f6307cddfb70195ca012343980a526b81a09749f) Update test expectation - this is being removed. - [`0c169af`](https://github.com/Comfy-Org/desktop/commit/0c169af7e1cacd99d49d333a775304b5795d18fe) Remove redundant code - [`426340b`](https://github.com/Comfy-Org/desktop/commit/426340b17ec8b1dbfb43152c710157a8ca3a1d31) Remove validation stages from InstallStage enum - [`1cfbaee`](https://github.com/Comfy-Org/desktop/commit/1cfbaee70f9900523d798073052c151d85d20d7e) Add pytorch, ComfyUI and Manager install stages - [`8c1b9af`](https://github.com/Comfy-Org/desktop/commit/8c1b9af0472cc4b1a2e9fcb7898645e48cb1bf66) Revert "Update test expectation - this is being removed." ### 📊 Changes **3 files changed** (+9 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+3 -10) 📝 `src/main-process/installStages.ts` (+5 -37) 📝 `src/main_types.ts` (+1 -1) </details> ### 📄 Description - Adds individual python package stages for pytorch, core, and manager. - Renames misleading InstallStageType => InstallStageName. - Removes redundant workaround. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1295-API-Rename-misleading-InstallStageType-InstallStageName-2646d73d365081008851f0af662c1182) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:22:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#1470
No description provided.