[PR #1302] [MERGED] Fix empty .venv folder breaks install #1474

New issue

Closed

opened 2026-10-31 22:22:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:22:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1302
Author: @webfiltered
Created: 9/9/2025
Status: ✅ Merged
Merged: 9/9/2025
Merged by: @webfiltered

Base: main ← Head: empty-venv-dir

📝 Commits (2)

e4cf821 Fix empty .venv folder breaks install
b9615a5 Fix missing import

📊 Changes

1 file changed (+14 additions, -2 deletions)

View changed files

📝 src/virtualEnvironment.ts (+14 -2)

📄 Description

Prevents installation from treating an empty .venv directory as a valid virtual environment.

Checks both directory existence and non-empty contents
Adds JSDoc documentation for the exists() method

Resolves issue where an empty .venv folder would incorrectly pass existence check.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1302 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 9/9/2025 **Status:** ✅ Merged **Merged:** 9/9/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `empty-venv-dir` --- ### 📝 Commits (2) - [`e4cf821`](https://github.com/Comfy-Org/desktop/commit/e4cf821b6f63582c0967d704de53f88a09f38224) Fix empty .venv folder breaks install - [`b9615a5`](https://github.com/Comfy-Org/desktop/commit/b9615a57cd9435f263c94677188bfbfecebf9c61) Fix missing import ### 📊 Changes **1 file changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+14 -2) </details> ### 📄 Description Prevents installation from treating an empty .venv directory as a valid virtual environment. - Checks both directory existence and non-empty contents - Adds JSDoc documentation for the exists() method Resolves issue where an empty .venv folder would incorrectly pass existence check. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1302-Fix-empty-venv-folder-breaks-install-2696d73d365081f7a581c5a279a86c8b) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:22:38 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1474

No description provided.

Rows
Columns