[PR #1306] [MERGED] Add check-only lint and format scripts for CI #1478

New issue

Closed

opened 2026-10-31 22:22:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:22:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1306
Author: @webfiltered
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @webfiltered

Base: main ← Head: restore-ci-lint-fail

📝 Commits (6)

a40b97d Add lint:check and format:check scripts for CI
b199af8 Update CI to use check-only lint and format scripts
a6709de Remove cache flags from CI check scripts
88d1674 Add CI-specific flags for stricter checking
3351f57 Merge branch 'main' into restore-ci-lint-fail
6b58d02 Restore file listing in CI Prettier checks

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 .github/workflows/ci.yaml (+3 -3)
📝 package.json (+2 -0)

📄 Description

Adds dedicated CI scripts that check but don't auto-fix.

Adds lint:check and format:check scripts without auto-fixing
Removes --cache flags (CI runs are stateless)
Uses --max-warnings 0 to fail on warnings
Changes Prettier log level to error for cleaner CI output

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1306 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `restore-ci-lint-fail` --- ### 📝 Commits (6) - [`a40b97d`](https://github.com/Comfy-Org/desktop/commit/a40b97da7d152fe3ceea9f827ef3661d9d9db86c) Add lint:check and format:check scripts for CI - [`b199af8`](https://github.com/Comfy-Org/desktop/commit/b199af85594088d4cd562df6b756f9abbad14bc8) Update CI to use check-only lint and format scripts - [`a6709de`](https://github.com/Comfy-Org/desktop/commit/a6709de82807ae26d180c6ab54041d8c227fcdc9) Remove cache flags from CI check scripts - [`88d1674`](https://github.com/Comfy-Org/desktop/commit/88d1674c36dec9651b83afce54872a611b68b003) Add CI-specific flags for stricter checking - [`3351f57`](https://github.com/Comfy-Org/desktop/commit/3351f57a8dfb0c3f185654cab015748d77effbb1) Merge branch 'main' into restore-ci-lint-fail - [`6b58d02`](https://github.com/Comfy-Org/desktop/commit/6b58d022a4bfb4b01b113ae0a63614d4fa7dca1f) Restore file listing in CI Prettier checks ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+3 -3) 📝 `package.json` (+2 -0) </details> ### 📄 Description Adds dedicated CI scripts that check but don't auto-fix. - Adds `lint:check` and `format:check` scripts without auto-fixing - Removes `--cache` flags (CI runs are stateless) - Uses `--max-warnings 0` to fail on warnings - Changes Prettier log level to error for cleaner CI output ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1306-Add-check-only-lint-and-format-scripts-for-CI-26a6d73d3650813b8609c4f879bdb1af) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:22:39 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1478

No description provided.

Rows
Columns