[GH-ISSUE #637] [DevTask] Avoid query of hardware stats on each metrics collection #194

Closed
opened 2026-10-31 22:09:54 +00:00 by bsakaguchi · 1 comment
Owner

Originally created by @huchenlei on GitHub (Jan 16, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/637

Currently gpu specs are queried for each frontend event tracked, which is unnecessary. The value should be cached.

github.com/Comfy-Org/desktop@06e10237cc/src/services/telemetry.ts (L113-L118)

┆Issue is synchronized with this Notion page by Unito

Originally created by @huchenlei on GitHub (Jan 16, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/637 Currently gpu specs are queried for each frontend event tracked, which is unnecessary. The value should be cached. https://github.com/Comfy-Org/desktop/blob/06e10237cc75fcb4dd4af8b289a5960b0c9b770d/src/services/telemetry.ts#L113-L118 ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-637-DevTask-Avoid-query-of-hardware-stats-on-each-metrics-collection-17d6d73d36508194bb59cf40cc393221) by [Unito](https://www.unito.io)
Author
Owner

@robinjhuang commented on GitHub (Jan 16, 2025):

Can take a look at this

<!-- gh-comment-id:2596412221 --> @robinjhuang commented on GitHub (Jan 16, 2025): Can take a look at this
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#194
No description provided.