[GH-ISSUE #708] [DevTask] Remove electron store async wrappers #209

New issue

Closed

opened 2026-10-31 22:10:07 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:10:07 +00:00

Owner

Originally created by @webfiltered on GitHub (Jan 23, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/708

Low priority:

An async wrapper was put in place to prevent disk issues from blocking execution. This was to resolve issues found in a simulation of poor drive performance. The repo has had significant work since then.

This should be re-verified, to determine if the async wrappers make any difference.

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (Jan 23, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/708 Low priority: An async wrapper was put in place to prevent disk issues from blocking execution. This was to resolve issues found in a simulation of poor drive performance. The repo has had significant work since then. This should be re-verified, to determine if the async wrappers make any difference. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-708-DevTask-Remove-electron-store-async-wrappers-1846d73d365081cb828efcc63b746d0c) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:10:07 +00:00

closed this issue
added the
performance
label

bsakaguchi commented

2026-10-31 22:10:08 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Apr 24, 2025):

Hi, @webfiltered. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

You suggested re-evaluating the async wrappers in the electron store.
These wrappers were initially added to address disk performance issues.
The repository has undergone substantial changes since then.
The task is marked as low priority and remains unresolved.

Next Steps:

Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Apr 24, 2025): Hi, @webfiltered. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - You suggested re-evaluating the async wrappers in the electron store. - These wrappers were initially added to address disk performance issues. - The repository has undergone substantial changes since then. - The task is marked as low priority and remains unresolved. **Next Steps:** - Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here. - If there is no further activity, the issue will be automatically closed in 7 days. Thank you for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:15:59 +00:00

[PR #209] [MERGED] Enh/use electron api to download models #688

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#209

No description provided.

Rows
Columns