[GH-ISSUE #715] [DevTask] Explicit virtual environment management in ComfyInstallation class #212

New issue

Closed

opened 2026-10-31 22:10:09 +00:00 by bsakaguchi · 2 comments

bsakaguchi commented

2026-10-31 22:10:09 +00:00

Owner

Originally created by @huchenlei on GitHub (Jan 24, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/715

Originally assigned to: @webfiltered on GitHub.

Currently virtual environment is recreated everytime basePath is updated implicitly.

github.com/Comfy-Org/desktop@a6a59f601a/src/main-process/comfyInstallation.ts (L38-L47)

We should make this more explicit, i.e. move the side effect in the setter to the callsites.

┆Issue is synchronized with this Notion page by Unito

Originally created by @huchenlei on GitHub (Jan 24, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/715 Originally assigned to: @webfiltered on GitHub. Currently virtual environment is recreated everytime basePath is updated implicitly. https://github.com/Comfy-Org/desktop/blob/a6a59f601a1db90c394095cfe687708bb2f43639/src/main-process/comfyInstallation.ts#L38-L47 We should make this more explicit, i.e. move the side effect in the setter to the callsites. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-715-DevTask-Explicit-virtual-environment-management-in-ComfyInstallation-class-1856d73d3650811ea9abf7d264ae36ba) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:10:09 +00:00

closed this issue
added the
enhancement
label

bsakaguchi commented

2026-10-31 22:10:10 +00:00

Author

Owner

@webfiltered commented on GitHub (Jan 24, 2025):

Thought I already had an issue for this, but apparently not - thanks!

@webfiltered commented on GitHub (Jan 24, 2025): Thought I already had an issue for this, but apparently not - thanks!

bsakaguchi commented

2026-10-31 22:10:10 +00:00

Author

Owner

@huchenlei commented on GitHub (Jan 28, 2025):

Fixed by https://github.com/Comfy-Org/desktop/pull/750

@huchenlei commented on GitHub (Jan 28, 2025): Fixed by https://github.com/Comfy-Org/desktop/pull/750

bsakaguchi referenced this issue

2026-10-31 22:16:02 +00:00

[PR #212] [MERGED] v0.2.10 #690