mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[GH-ISSUE #833] Replace node-pty with a proper progress bar. #232
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#232
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @robinjhuang on GitHub (Feb 5, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/833
Originally assigned to: @webfiltered on GitHub.
Using RUST_LOG=trace, we can get proper output from uv for python and pip installs. Would be good to replace the current log output with a progress bar.
Node-pty can cause some issues on powershell on some issues
Also, the uv output can seem like something suspicious is happening during an install
┆Issue is synchronized with this Notion page by Unito
@robinjhuang commented on GitHub (Feb 6, 2025):
Looks like uv might have something implemented already
https://github.com/astral-sh/uv/pull/11165
@dosubot[bot] commented on GitHub (May 8, 2025):
Hi, @robinjhuang. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.
Issue Summary:
RUST_LOG=tracefor better visibility.node-ptyon PowerShell and suspiciousuvoutput.uvrepository that might address the issue.Next Steps:
Thank you for your understanding and contribution!