[GH-ISSUE #933] [DevTask] Remove terminal.restore API #254

New issue

Closed

opened 2026-10-31 22:10:39 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:10:39 +00:00

Owner

Originally created by @webfiltered on GitHub (Feb 17, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/933

Terminal keeps an array of raw output strings as the terminal buffer, and restore() returns the raw strings when requested. They are fed via IPC on a delay to the frontend. As we are using a full pty, this design causes various issues.

We should remove this raw buffer and instead utilise the pty buffer to handle save/restore - thus removing the need to replay every control character at potentially different width/height.

Originally created by @webfiltered on GitHub (Feb 17, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/933 `Terminal` keeps an array of raw output strings as the terminal buffer, and `restore()` returns the raw strings when requested. They are fed via IPC on a delay to the frontend. As we are using a full pty, this design causes various issues. We should remove this raw buffer and instead utilise the pty buffer to handle save/restore - thus removing the need to replay every control character at potentially different width/height.

bsakaguchi closed this issue

2026-10-31 22:10:40 +00:00

bsakaguchi commented

2026-10-31 22:10:40 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (May 19, 2025):

Hi, @webfiltered. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

Proposal to remove terminal.restore API due to reliance on raw output strings.
Suggestion to use the pty buffer for save and restore operations.
No comments or additional activity on the issue.

Next Steps:

Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here.
If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (May 19, 2025): Hi, @webfiltered. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - Proposal to remove `terminal.restore` API due to reliance on raw output strings. - Suggestion to use the pty buffer for save and restore operations. - No comments or additional activity on the issue. **Next Steps:** - Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here. - If there is no further activity, the issue will be automatically closed in 7 days. Thank you for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:16:23 +00:00

[PR #254] [CLOSED] Rename extra model config functions for readability. #730

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#254

No description provided.

Rows
Columns