[GH-ISSUE #1063] [DevTask] Prefer async filesystem API over synchronous #288

New issue

Closed

opened 2026-10-31 22:11:12 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:11:12 +00:00

Owner

Originally created by @webfiltered on GitHub (Mar 16, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1063

Issue

Synchronous FS access can block a process. Depending on how the supporting code is written, it may either do nothing because async is layered elsewhere, cause a stuttering effect for a slow / congested filesystem, or completely freeze part/all of the interface.

Solution

Replace all synchronous filesystem access with async (node:fs/promises), and use excessive-but-reasonable timeouts with error handling.

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (Mar 16, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1063 ### Issue Synchronous FS access can block a process. Depending on how the supporting code is written, it may either do nothing because async is layered elsewhere, cause a stuttering effect for a slow / congested filesystem, or completely freeze part/all of the interface. ### Solution Replace all synchronous filesystem access with async (`node:fs/promises`), and use excessive-but-reasonable timeouts with error handling. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1063-DevTask-Prefer-async-filesystem-API-over-synchronous-1b86d73d365081e695b4d9f862546f50) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:11:12 +00:00

closed this issue
added the
enhancement
label

bsakaguchi commented

2026-10-31 22:11:12 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Sep 6, 2025):

Hi, @webfiltered. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

I suggested replacing synchronous filesystem operations with asynchronous APIs from node:fs/promises to prevent interface blocking and improve responsiveness.
I also recommended adding timeouts and robust error handling to enhance reliability.
There has been no further activity or comments on this issue since my initial suggestion.

Next Steps:

Please let me know if this issue is still relevant with the latest version of the desktop app by commenting here.
If I don’t hear back within 7 days, this issue will be automatically closed.

Thanks for your understanding and contribution!

@dosubot[bot] commented on GitHub (Sep 6, 2025): Hi, @webfiltered. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog and am marking this issue as stale. **Issue Summary:** - I suggested replacing synchronous filesystem operations with asynchronous APIs from `node:fs/promises` to prevent interface blocking and improve responsiveness. - I also recommended adding timeouts and robust error handling to enhance reliability. - There has been no further activity or comments on this issue since my initial suggestion. **Next Steps:** - Please let me know if this issue is still relevant with the latest version of the desktop app by commenting here. - If I don’t hear back within 7 days, this issue will be automatically closed. Thanks for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:16:38 +00:00

[PR #288] [MERGED] Rename SendCrashStatistics to SendStatistics #758

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#288

No description provided.

Rows
Columns