[GH-ISSUE #1110] [DevTask] Convert core build optionalBranch to use commit hash #306

New issue

Closed

opened 2026-10-31 22:11:23 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:11:23 +00:00

Owner

Originally created by @webfiltered on GitHub (Apr 22, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1110

The build process uses branches if cherry-picked commits are required to supplement a stable release. Branch HEAD can be changed, and are likely to be removed, which breaks build reproducibility.

Recommendation:

Set a tag on the commit to block orphaned commit clean up
Update the build process to pull the commit SHA (if tag is altered and original commit lost, build should fail)

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (Apr 22, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1110 The build process uses branches if cherry-picked commits are required to supplement a stable release. Branch HEAD can be changed, and are likely to be removed, which breaks build reproducibility. Recommendation: 1. Set a tag on the commit to block orphaned commit clean up 2. Update the build process to pull the commit SHA (if tag is altered and original commit lost, build should fail) ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1110-DevTask-Convert-core-build-optionalBranch-to-use-commit-hash-1dd6d73d365081bc8daacb346680d121) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:11:23 +00:00

closed this issue
added the
enhancement
label

bsakaguchi commented

2026-10-31 22:11:23 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Sep 20, 2025):

Hi, @webfiltered. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

You suggested improving build reproducibility by using commit hashes instead of branch names in the core build's optionalBranch process.
Your proposal included tagging commits to prevent cleanup and modifying the build to depend on commit SHAs.
This change would cause builds to fail if the referenced commit is missing, enhancing reliability.
There has been no further discussion or activity on this suggestion since it was opened.

Next Steps:

Please let me know if this issue is still relevant to the latest version of the desktop app by commenting here.
If I don’t hear back within 7 days, I will automatically close this issue.

Thanks for your understanding and contribution!

@dosubot[bot] commented on GitHub (Sep 20, 2025): Hi, @webfiltered. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog and am marking this issue as stale. **Issue Summary:** - You suggested improving build reproducibility by using commit hashes instead of branch names in the core build's optionalBranch process. - Your proposal included tagging commits to prevent cleanup and modifying the build to depend on commit SHAs. - This change would cause builds to fail if the referenced commit is missing, enhancing reliability. - There has been no further discussion or activity on this suggestion since it was opened. **Next Steps:** - Please let me know if this issue is still relevant to the latest version of the desktop app by commenting here. - If I don’t hear back within 7 days, I will automatically close this issue. Thanks for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:12:49 +00:00

[GH-ISSUE #1474] [Bug]: The Manage Extensions in the MENU, is not a replacement for the ComfyUI Manager. #424

bsakaguchi referenced this issue

2026-10-31 22:16:49 +00:00

[PR #306] [MERGED] Prevent resizing window below useful size #774