Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-04 23:47:43 +00:00

[GH-ISSUE #1179] [CI] Create playwright test expectation update script #325

New issue

Closed

opened 2026-10-31 22:11:37 +00:00 by bsakaguchi · 8 comments

bsakaguchi commented

2026-10-31 22:11:37 +00:00

Owner

Originally created by @webfiltered on GitHub (May 27, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1179

Frontend CI may be able to be copied over without much effort

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (May 27, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1179 Frontend CI may be able to be copied over without much effort ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1179-CI-Create-playwright-test-expectation-update-script-2006d73d3650818f89ecc3c648f326d0) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:11:37 +00:00

closed this issue
added the
Bounty
label

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@robinjhuang commented on GitHub (May 29, 2025):

This Issues has been set to be bounty, here is the link on how to sign up for this bounty: https://comfyorg.notion.site/ComfyUI-Bounty-Tasks-1fb6d73d36508064af76d05b3f35665f or click here to sign up

@robinjhuang commented on GitHub (May 29, 2025): This Issues has been set to be bounty, here is the link on how to sign up for this bounty: https://comfyorg.notion.site/ComfyUI-Bounty-Tasks-1fb6d73d36508064af76d05b3f35665f or [click here to sign up](mailto:bounty@comfy.org?subject=I%20can%20help%20%5B%5BCI%5D%20Create%20playwright%20test%20expectation%20update%20script%5D&body=I%20can%20help%20with%20%5B%5BCI%5D%20Create%20playwright%20test%20expectation%20update%20script%5D(%20https%3A%2F%2Fgithub.com%2FComfy-Org%2Fdesktop%2Fissues%2F1179%20)%0A%0AMy%20approach%20is%20...%0A%0AMy%20timeline%20is%20...)

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@christian-byrne commented on GitHub (Jun 11, 2025):

"Frontend CI [workflow]" refers to https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/.github/workflows/test-browser-exp.yaml

@christian-byrne commented on GitHub (Jun 11, 2025): "Frontend CI [workflow]" refers to https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/.github/workflows/test-browser-exp.yaml

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@christian-byrne commented on GitHub (Jun 11, 2025):

The workflow run Playwright tests and update snapshots then commits the updated expectations.

@christian-byrne commented on GitHub (Jun 11, 2025): The workflow run Playwright tests and update snapshots then commits the updated expectations.

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@Myestery commented on GitHub (Jun 14, 2025):

Hi @christian-byrne
I'm trying to work on this issue and have communicated internally with the team.
I'll like to know explicitly what needs to be done to the workflow so I can proceed with my solution

Does it suffice to just add playwright tests to the CI workflow?

@Myestery commented on GitHub (Jun 14, 2025): Hi @christian-byrne I'm trying to work on this issue and have communicated internally with the team. I'll like to know explicitly what needs to be done to the workflow so I can proceed with my solution Does it suffice to just add playwright tests to the [CI](https://github.com/Comfy-Org/desktop/blob/main/.github/workflows/ci.yaml) workflow?

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@christian-byrne commented on GitHub (Jun 14, 2025):

Hi! For this, we want a workflow that can update the test screenshot expectations and then commit those updated screenshots to a PR. You can see in this example: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/.github/workflows/test-browser-exp.yaml that it works like: (1) we make a PR that changes behavior of playwright tests that use screenshots, (2) we add a specific label to the PR, (3) the workflow runs and commits the newly updated screenshot expections directly onto our PR.

You can also check in that (ComfyUI_frontend) repo to see past PRs that had the label applied and see the commit history to understand a bit more about the process.

@christian-byrne commented on GitHub (Jun 14, 2025): Hi! For this, we want a workflow that can update the test screenshot expectations and then commit those updated screenshots to a PR. You can see in this example: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/.github/workflows/test-browser-exp.yaml that it works like: (1) we make a PR that changes behavior of playwright tests that use screenshots, (2) we add a specific label to the PR, (3) the workflow runs and commits the newly updated screenshot expections directly onto our PR. You can also check in that (ComfyUI_frontend) repo to see past PRs that had the label applied and see the commit history to understand a bit more about the process.

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@BenraouaneSoufiane commented on GitHub (Jun 19, 2025):

Hello, can I work on this for 250$?

@BenraouaneSoufiane commented on GitHub (Jun 19, 2025): Hello, can I work on this for 250$?

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@kevinpaik1 commented on GitHub (Jun 26, 2025):

@Myestery thank you for your contribution!

@kevinpaik1 commented on GitHub (Jun 26, 2025): @Myestery thank you for your contribution!

bsakaguchi commented

2026-10-31 22:11:38 +00:00

Author

Owner

@Myestery commented on GitHub (Jun 26, 2025):

@Myestery thank you for your contribution!

Glad I was able to help

@Myestery commented on GitHub (Jun 26, 2025): > @Myestery thank you for your contribution! Glad I was able to help

bsakaguchi referenced this issue

2026-10-31 22:16:59 +00:00

[PR #325] [MERGED] Prevent mutation of the default settings object #791

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#325

No description provided.

Rows
Columns