Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-05 07:57:46 +00:00

[GH-ISSUE #1330] Migrate validation logic out of frontend Vue components #368

New issue

Closed

opened 2026-10-31 22:12:08 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:12:08 +00:00

Owner

Originally created by @webfiltered on GitHub (Sep 20, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1330

Copied from: https://github.com/Comfy-Org/desktop/pull/1329

Tracking issue for follow-up.

Current

Actual disk size validation happens in the desktop code, but the decision to continue / block install is currently owned by the frontend.

Ref: https://github.com/Comfy-Org/desktop/issues/1277#issuecomment-3314373089

Follow-up

This needs to be properly cleaned up so that desktop controls what desktop does. It is illogical for the front end to be the owner of the decision to allow the desktop app to install or not.

Double-validation provides excellent UX when a delay between frontend and backend is possible (e.g. web app). This validation logic needs to be owned solely by the Electron code.

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (Sep 20, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1330 - Copied from: https://github.com/Comfy-Org/desktop/pull/1329 Tracking issue for follow-up. ### Current Actual disk size validation happens in the desktop code, but the decision to continue / block install is currently owned by the frontend. - Ref: https://github.com/Comfy-Org/desktop/issues/1277#issuecomment-3314373089 ### Follow-up This needs to be properly cleaned up so that desktop controls what desktop does. It is illogical for the front end to be the owner of the decision to allow the desktop app to install or not. Double-validation provides excellent UX when a delay between frontend and backend is _possible_ (e.g. web app). This validation logic needs to be owned solely by the Electron code. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1330-Migrate-validation-logic-out-of-frontend-Vue-components-2746d73d3650817a9f8dfaff9adfb344) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:12:08 +00:00

closed this issue
added the
enhancement
label

bsakaguchi commented

2026-10-31 22:12:08 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Dec 20, 2025):

Hi, @webfiltered. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

You suggested moving disk size validation from the frontend Vue components to the Electron desktop app.
The goal is to centralize validation logic for better consistency and user experience.
This would prevent split validation responsibilities between frontend and backend.
No further comments or activity have been recorded on this issue.

Next Steps:

Please let me know if this issue is still relevant with the latest version of the desktop app by commenting here.
If I don’t hear back within 7 days, this issue will be automatically closed.

Thanks for your understanding and contribution!

@dosubot[bot] commented on GitHub (Dec 20, 2025): Hi, @webfiltered. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog and am marking this issue as stale. **Issue Summary:** - You suggested moving disk size validation from the frontend Vue components to the Electron desktop app. - The goal is to centralize validation logic for better consistency and user experience. - This would prevent split validation responsibilities between frontend and backend. - No further comments or activity have been recorded on this issue. **Next Steps:** - Please let me know if this issue is still relevant with the latest version of the desktop app by commenting here. - If I don’t hear back within 7 days, this issue will be automatically closed. Thanks for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:17:12 +00:00

[PR #368] [MERGED] Fixes running uv command with spaces in path #823

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#368

No description provided.

Rows
Columns