Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-05 07:57:46 +00:00

[GH-ISSUE #1483] Required check stuck as “Expected” when PR only touches `scripts/**` (workflow skipped by paths-ignore) #432

New issue

Closed

opened 2026-10-31 22:12:55 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:12:55 +00:00

Owner

Originally created by @benceruleanlu on GitHub (Dec 14, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1483

When a PR only changes files under scripts/** (e.g. scripts/downloadFrontend.js in PR #1479), the required status check build-and-test-e2e-windows / integration-windows-test stays in “Expected — Waiting for status to be reported” and blocks merging.

Why this happens

The required check is produced by the reusable workflow call job build-and-test-e2e-windows in .github/workflows/debug_all.yml.
.github/workflows/debug_all.yml has on.pull_request.paths-ignore (and push.paths-ignore) including scripts/**.
So for script-only changes, the entire workflow is skipped, meaning the required check is never created/reported.

Impact

If branch protection requires build-and-test-e2e-windows / integration-windows-test, script-only PRs become unmergeable unless checks are manually bypassed.

Possible fixes

Adjust .github/workflows/debug_all.yml paths-ignore so scripts/downloadFrontend.js (or all scripts/**) triggers the workflow.
Update branch protection required checks to not require this job when the workflow is path-filtered.
Add a manual escape hatch: allow running debug_all.yml via workflow_dispatch and ensure branch protection accepts manually-triggered runs.

Example

PR #1479

┆Issue is synchronized with this Notion page by Unito

Originally created by @benceruleanlu on GitHub (Dec 14, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1483 When a PR only changes files under `scripts/**` (e.g. `scripts/downloadFrontend.js` in PR #1479), the required status check `build-and-test-e2e-windows / integration-windows-test` stays in **“Expected — Waiting for status to be reported”** and blocks merging. **Why this happens** - The required check is produced by the reusable workflow call job `build-and-test-e2e-windows` in `.github/workflows/debug_all.yml`. - `.github/workflows/debug_all.yml` has `on.pull_request.paths-ignore` (and `push.paths-ignore`) including `scripts/**`. - So for script-only changes, the entire workflow is skipped, meaning the required check is never created/reported. **Impact** - If branch protection requires `build-and-test-e2e-windows / integration-windows-test`, script-only PRs become unmergeable unless checks are manually bypassed. **Possible fixes** 1) Adjust `.github/workflows/debug_all.yml` `paths-ignore` so `scripts/downloadFrontend.js` (or all `scripts/**`) triggers the workflow. 2) Update branch protection required checks to not require this job when the workflow is path-filtered. 3) Add a manual escape hatch: allow running `debug_all.yml` via `workflow_dispatch` and ensure branch protection accepts manually-triggered runs. **Example** - PR #1479 ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1483-Required-check-stuck-as-Expected-when-PR-only-touches-scripts-workflow-skipped-2c96d73d365081ea9448c8f77c26de01) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:12:55 +00:00

closed this issue
added the
bug
label

bsakaguchi commented

2026-10-31 22:12:56 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Mar 15, 2026):

Hi, @benceruleanlu. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

The required status check build-and-test-e2e-windows / integration-windows-test remains stuck as "Expected" for PRs modifying only scripts/** files.
This happens because the workflow is skipped due to paths-ignore settings, causing branch protection rules to block merging.
You suggested possible fixes like adjusting paths-ignore, changing branch protection requirements, or enabling manual workflow triggers.
No further comments or updates have been made on this issue.

Next Steps:

Please let me know if this issue is still relevant with the latest version of the desktop app by commenting here.
If I don’t hear back within 7 days, I will automatically close this issue.

Thanks for your understanding and contribution!

@dosubot[bot] commented on GitHub (Mar 15, 2026): Hi, @benceruleanlu. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog and am marking this issue as stale. **Issue Summary:** - The required status check `build-and-test-e2e-windows / integration-windows-test` remains stuck as "Expected" for PRs modifying only `scripts/**` files. - This happens because the workflow is skipped due to `paths-ignore` settings, causing branch protection rules to block merging. - You suggested possible fixes like adjusting `paths-ignore`, changing branch protection requirements, or enabling manual workflow triggers. - No further comments or updates have been made on this issue. **Next Steps:** - Please let me know if this issue is still relevant with the latest version of the desktop app by commenting here. - If I don’t hear back within 7 days, I will automatically close this issue. Thanks for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:17:33 +00:00

[PR #432] [MERGED] Update to 0.3.25 (Types) #861

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#432

No description provided.

Rows
Columns

[GH-ISSUE #1483] Required check stuck as “Expected” when PR only touches scripts/** (workflow skipped by paths-ignore) #432

[GH-ISSUE #1483] Required check stuck as “Expected” when PR only touches `scripts/**` (workflow skipped by paths-ignore) #432