Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-04 23:47:43 +00:00

[GH-ISSUE #1517] Follow-up: versioned settings migration for torch mirror defaults #442

New issue

Closed

opened 2026-10-31 22:13:04 +00:00 by bsakaguchi · 2 comments

bsakaguchi commented

2026-10-31 22:13:04 +00:00

Owner

Originally created by @benceruleanlu on GitHub (Jan 8, 2026).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1517

Hotfix in place to migrate legacy cu129 torch mirror to cu130 for NVIDIA installs.\n\nFollow-up (long-term): move to versioned settings migrations in ComfySettings and track whether torch mirror was user-set vs default.\n\nProposed scope:\n- Add Comfy-Desktop.SettingsSchemaVersion + migration pipeline in ComfySettings.load()\n- Track default vs user-set torch mirror (e.g., TorchMirrorSource or TorchMirrorWasDefault)\n- Migrate legacy torch mirror only when it was default\n- Remove ad-hoc migration in ComfyInstallation/virtualEnvironment once schema migration exists\n\nNotes:\n- Hotfix can ship now; this issue replaces it with a safer long-term approach.\n

┆Issue is synchronized with this Notion page by Unito

Originally created by @benceruleanlu on GitHub (Jan 8, 2026). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1517 Hotfix in place to migrate legacy cu129 torch mirror to cu130 for NVIDIA installs.\n\nFollow-up (long-term): move to versioned settings migrations in ComfySettings and track whether torch mirror was user-set vs default.\n\nProposed scope:\n- Add Comfy-Desktop.SettingsSchemaVersion + migration pipeline in ComfySettings.load()\n- Track default vs user-set torch mirror (e.g., TorchMirrorSource or TorchMirrorWasDefault)\n- Migrate legacy torch mirror only when it was default\n- Remove ad-hoc migration in ComfyInstallation/virtualEnvironment once schema migration exists\n\nNotes:\n- Hotfix can ship now; this issue replaces it with a safer long-term approach.\n ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1517-Follow-up-versioned-settings-migration-for-torch-mirror-defaults-2e26d73d36508178bf0adb1071c5d86d) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:13:04 +00:00

closed this issue
added the
Planned
label

bsakaguchi commented

2026-10-31 22:13:05 +00:00

Author

Owner

@coderabbitai[bot] commented on GitHub (Jan 8, 2026):

🔗 Related PRs

Comfy-Org/desktop#1512 - Update NVIDIA PyTorch to 2.9.1 cu130 [merged]
Comfy-Org/desktop#1513 - Update NVIDIA torch version on updates [closed]

Enable issue planning

_{To enable issue planning, add the following to your .coderabbit.yaml:}

issue_enrichment:
  planning:
    enabled: true

_{You can then request a plan by commenting @coderabbitai plan on any issue.}

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

@coderabbitai[bot] commented on GitHub (Jan 8, 2026):  <details> <summary>🔗 Related PRs</summary> Comfy-Org/desktop#1512 - Update NVIDIA PyTorch to 2.9.1 cu130 [merged] Comfy-Org/desktop#1513 - Update NVIDIA torch version on updates [closed] </details> --- <details> <summary>Enable issue planning</summary> To enable issue planning, add the following to your `.coderabbit.yaml`: ```yaml issue_enrichment: planning: enabled: true ``` You can then request a plan by commenting `@coderabbitai plan` on any issue. </details> <details> <summary> 🧪 Issue enrichment is currently in open beta.</summary> You can configure auto-planning by selecting labels in the issue_enrichment configuration. To disable automatic issue enrichment, add the following to your `.coderabbit.yaml`: ```yaml issue_enrichment: auto_enrich: enabled: false ``` </details> 💬 Have feedback or questions? Drop into our [discord](https://discord.gg/coderabbit)!

bsakaguchi commented

2026-10-31 22:13:05 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Apr 9, 2026):

Hi, @benceruleanlu. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

You proposed implementing versioned settings migrations in ComfySettings to handle legacy torch mirror settings safely.
The plan involves adding a settings schema version, creating a migration pipeline, and removing the current ad-hoc migration after deployment.
A hotfix is currently in place as a temporary solution.
The issue remains unresolved and is intended to replace the hotfix with a more structured long-term approach.
Maintainer coderabbitai has provided an auto-generated issue plan referencing related PRs.

Next Steps:

Please let us know if this issue is still relevant to the latest version of the desktop app by commenting here to keep the discussion open.
If we do not hear back within 7 days, this issue will be automatically closed.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Apr 9, 2026): Hi, @benceruleanlu. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog and am marking this issue as stale. **Issue Summary:** - You proposed implementing versioned settings migrations in ComfySettings to handle legacy torch mirror settings safely. - The plan involves adding a settings schema version, creating a migration pipeline, and removing the current ad-hoc migration after deployment. - A hotfix is currently in place as a temporary solution. - The issue remains unresolved and is intended to replace the hotfix with a more structured long-term approach. - Maintainer coderabbitai has provided an auto-generated issue plan referencing related PRs. **Next Steps:** - Please let us know if this issue is still relevant to the latest version of the desktop app by commenting here to keep the discussion open. - If we do not hear back within 7 days, this issue will be automatically closed. Thank you for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:17:38 +00:00

[PR #442] [MERGED] feat: Initial integration test with Playwright #869

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#442

No description provided.

Rows
Columns