Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-04 23:47:43 +00:00

[GH-ISSUE #1566] macOS compiled requirements include CUDA extra-index URL (cu130) #462

New issue

Closed

opened 2026-10-31 22:13:18 +00:00 by bsakaguchi · 2 comments

bsakaguchi commented

2026-10-31 22:13:18 +00:00

Owner

Originally created by @benceruleanlu on GitHub (Jan 28, 2026).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1566

Originally assigned to: @benceruleanlu on GitHub.

We currently compile assets/requirements/macos.compiled with --extra-index-url https://download.pytorch.org/whl/cu130, which is CUDA-only and not applicable to macOS. This is likely leftover from using assets/override.txt for macOS compiles.

Question: Should we remove the CUDA extra index for macOS compiles (and/or use a macOS-specific override file) to avoid unnecessary index noise and potential resolution drift?

Notes:

The macOS compile command in the file header includes --override assets/override.txt.
override.txt adds --extra-index-url https://download.pytorch.org/whl/cu130.
macOS wheels won’t be on the CUDA index, but it still affects resolver ordering.

Leaving for follow-up.

┆Issue is synchronized with this Notion page by Unito

Originally created by @benceruleanlu on GitHub (Jan 28, 2026). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1566 Originally assigned to: @benceruleanlu on GitHub. We currently compile `assets/requirements/macos.compiled` with `--extra-index-url https://download.pytorch.org/whl/cu130`, which is CUDA-only and not applicable to macOS. This is likely leftover from using `assets/override.txt` for macOS compiles. Question: Should we remove the CUDA extra index for macOS compiles (and/or use a macOS-specific override file) to avoid unnecessary index noise and potential resolution drift? Notes: - The macOS compile command in the file header includes `--override assets/override.txt`. - `override.txt` adds `--extra-index-url https://download.pytorch.org/whl/cu130`. - macOS wheels won’t be on the CUDA index, but it still affects resolver ordering. Leaving for follow-up. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1566-macOS-compiled-requirements-include-CUDA-extra-index-URL-cu130-2f66d73d365081fe8c6fc8414a48b6b6) by [Unito](https://www.unito.io)

bsakaguchi

2026-10-31 22:13:18 +00:00

closed this issue
added the
question
label

bsakaguchi commented

2026-10-31 22:13:18 +00:00

Author

Owner

@coderabbitai[bot] commented on GitHub (Jan 28, 2026):

📝 CodeRabbit Plan Mode

Generate an implementation plan and prompts that you can use with your favorite coding agent.

Create Plan

Examples

🔗 Related PRs

Comfy-Org/desktop#1512 - Update NVIDIA PyTorch to 2.9.1 cu130 [merged]

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

@coderabbitai[bot] commented on GitHub (Jan 28, 2026):  ### 📝 CodeRabbit Plan Mode Generate an implementation plan and prompts that you can use with your favorite coding agent. - [ ]  Create Plan <details> <summary>Examples</summary> - [Example 1](https://redirect.github.com/coderabbitai/git-worktree-runner/issues/29#issuecomment-3589134556) - [Example 2](https://redirect.github.com/coderabbitai/git-worktree-runner/issues/12#issuecomment-3606665167) </details> --- <details> <summary><b>🔗 Related PRs</b></summary> Comfy-Org/desktop#1512 - Update NVIDIA PyTorch to 2.9.1 cu130 [merged] </details> --- <details> <summary> 🧪 Issue enrichment is currently in open beta.</summary> You can configure auto-planning by selecting labels in the issue_enrichment configuration. To disable automatic issue enrichment, add the following to your `.coderabbit.yaml`: ```yaml issue_enrichment: auto_enrich: enabled: false ``` </details> 💬 Have feedback or questions? Drop into our [discord](https://discord.gg/coderabbit)!

bsakaguchi commented

2026-10-31 22:13:19 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Apr 29, 2026):

Hi, @benceruleanlu. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

You identified that the macOS compiled requirements file includes a CUDA-specific extra index URL, which is unnecessary for macOS.
This inclusion could cause resolver noise or potential resolution problems on macOS.
You suggested removing the CUDA extra index or applying a macOS-specific override.
I generated an implementation plan template, but no concrete resolution or further input has been provided.
The issue remains open without progress toward a fix.

Next Steps:

Please let us know if this issue is still relevant with the latest version of the desktop app by commenting here to keep the discussion open.
If we do not hear back within 7 days, this issue will be automatically closed.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Apr 29, 2026): Hi, @benceruleanlu. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog and am marking this issue as stale. **Issue Summary:** - You identified that the macOS compiled requirements file includes a CUDA-specific extra index URL, which is unnecessary for macOS. - This inclusion could cause resolver noise or potential resolution problems on macOS. - You suggested removing the CUDA extra index or applying a macOS-specific override. - I generated an implementation plan template, but no concrete resolution or further input has been provided. - The issue remains open without progress toward a fix. **Next Steps:** - Please let us know if this issue is still relevant with the latest version of the desktop app by commenting here to keep the discussion open. - If we do not hear back within 7 days, this issue will be automatically closed. Thank you for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:17:45 +00:00

[PR #462] [MERGED] v0.3.31 #885

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#462

No description provided.

Rows
Columns