mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[GH-ISSUE #1585] [Bug]: Despite having the option "Show confirmation dialog when closing the ComfyUI browser interface" ticked, my comfyUI desktop close without any warning #469
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#469
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @msnbcorp on GitHub (Feb 3, 2026).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1585
Originally assigned to: @benceruleanlu on GitHub.
App Version
All is in the title : I have the option : "Show confirmation dialog when closing the ComfyUI browser interface" selected in the settings of comfyUI desktop. But despite that it doesn't seem to give the wanted result.
Expected Behavior
A warning about process currently running AND unsaved works.
Actual Behavior
Nothing, it just close (dans weirdly, sometimes some process keep existing in the windows task manager ... )
Steps to Reproduce
Install a fresh comfyUI desktop, made a unsaved work, launch a process, close ComfyUI desktop.
Debug Logs
Browser Logs
No response
Settings JSON
No response
Other
No response
┆Issue is synchronized with this Notion page by Unito
@dosubot[bot] commented on GitHub (Feb 3, 2026):
Hi @msnbcorp! I'm Dosu and I’m helping the desktop team.
The confirmation dialog on close is not currently implemented in the ComfyUI Desktop app's main process, even though the setting exists and is enabled by default. The code only logs the close event and does not check or act on the confirmation dialog setting, so the app closes immediately without warning, regardless of unsaved work or running processes. This is a known issue, and there are reports of related problems like the app freezing or leaving processes running in the task manager. Some users have found that disabling the "Show confirmation when closing window" setting can help with freeze issues, but it won't enable a confirmation dialog—because that feature isn't wired up in the desktop app yet. For now, there is no workaround to get the confirmation dialog to appear on close in the desktop version.
Reference
Related issue
To reply, just mention @dosu.
Share context across your team and agents. Try Dosu.
@msnbcorp commented on GitHub (Feb 3, 2026):
@dosu, thanks to the bot to clarifying the situation. I think the situation could be solve without a lot of work.
@dosubot[bot] commented on GitHub (Feb 3, 2026):
Agreed—the fix should be pretty straightforward. Right now, the main process just logs the close event and doesn’t check the confirmation dialog setting or show any prompt, even though the Dialog API for custom dialogs is already in place and ready to use (reference, Dialog API PR).
To implement the confirmation dialog, you’d intercept the window’s
closeevent, check if the setting is enabled, and call the dialog to ask the user for confirmation. If you want pointers to the relevant files or a quick outline of the logic, just let me know!To reply, just mention @dosu.
Share context across your team and agents. Try Dosu.
@msnbcorp commented on GitHub (Feb 3, 2026):
@desu, unfortunetly, i am not good with typescript, javascript etc, but you could point to the right parts and give a quick outline of the logic for others that want to work on the issue.
@benceruleanlu commented on GitHub (Feb 4, 2026):
Hey, thanks for the report. I think I know why this is happening. The setting was probably added for the browser environment and doesn't cooperate well with the desktop Electron environment. So I'm working on a fix right now for that