Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-04 23:47:43 +00:00

[GH-ISSUE #1713] [Feature Request]: Make installation error dialogs translatable (hardcoded English strings) #521

New issue

Closed

opened 2026-10-31 22:14:02 +00:00 by bsakaguchi · 1 comment

bsakaguchi commented

2026-10-31 22:14:02 +00:00

Owner

Originally created by @ghost on GitHub (May 5, 2026).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1713

Problem Statement

During the ComfyUI Desktop installation process (v0.8.36), several error messages and confirmation dialogs are hardcoded in English, making them difficult to understand for non-English-speaking users.

After clicking "Install" and during the installation flow, the following dialog messages appear in English:

Git missing dialog: "We were unable to find git on this device. Please download and install git before continuing with the installation of ComfyUI Desktop."
Failed to create virtual environment dialog: "Failed to create virtual environment" + detail "ComfyUI Desktop was unable to set up the Python environment required to run..."
Venv reinstall prompt: "Would you like to remove your .venv directory and reinstall it?"
NVIDIA driver too old dialog: "Your NVIDIA driver may be too old for PyTorch..."
Critical error dialog: "An error was detected with your installation..."
The validation error message prefix: "Validation error: {error}"

These dialog.showMessageBox() / dialog.showErrorBox() calls bypass the vue-i18n locale system used by the rest of the app, so they always show in English regardless of the user's language setting.

Proposed Solution

Replace the hardcoded English strings in installation dialogs with locale-aware lookups. Since these dialogs are rendered via Electron's native dialog.showMessageBox() in the main process (not in the Vue renderer), the approach could be:

Read the user's selected locale from the desktop config
Use a simple key-based string lookup in the main process that maps dialog messages to the appropriate locale
Fall back to English if the locale is not available

Alternatively, if the dialogs can be moved from native dialog.showMessageBox() to Vue-based custom dialogs in the renderer process, they would automatically use the existing vue-i18n locale system.

Potential workflow

User selects a language in settings (or uses system default)
User clicks Install
If an error occurs during installation (e.g., Python environment setup fails), the error dialog appears in the user's selected language instead of English
The same applies to all confirmation prompts during the installation flow

Impact Level

High (Major improvement)

Alternatives Considered

Keeping the current behavior and only translating the in-UI progress text (which already uses vue-i18n). However, the native error dialogs are the most critical during installation since they often appear when something goes wrong, and users need to understand the error to resolve it.
Documenting the English error messages in a FAQ. This would be less effective since users encounter the error before they can search for help.

Version: ComfyUI Desktop v0.8.36 (latest release)

Originally created by @ghost on GitHub (May 5, 2026). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1713 ### Problem Statement During the ComfyUI Desktop installation process (v0.8.36), several error messages and confirmation dialogs are hardcoded in English, making them difficult to understand for non-English-speaking users. After clicking "Install" and during the installation flow, the following dialog messages appear in English: 1. **Git missing dialog**: "We were unable to find git on this device. Please download and install git before continuing with the installation of ComfyUI Desktop." 2. **Failed to create virtual environment dialog**: "Failed to create virtual environment" + detail "ComfyUI Desktop was unable to set up the Python environment required to run..." 3. **Venv reinstall prompt**: "Would you like to remove your .venv directory and reinstall it?" 4. **NVIDIA driver too old dialog**: "Your NVIDIA driver may be too old for PyTorch..." 5. **Critical error dialog**: "An error was detected with your installation..." 6. **The validation error message prefix**: "Validation error: {error}" These `dialog.showMessageBox()` / `dialog.showErrorBox()` calls bypass the vue-i18n locale system used by the rest of the app, so they always show in English regardless of the user's language setting. ### Proposed Solution Replace the hardcoded English strings in installation dialogs with locale-aware lookups. Since these dialogs are rendered via Electron's native `dialog.showMessageBox()` in the main process (not in the Vue renderer), the approach could be: 1. Read the user's selected locale from the desktop config 2. Use a simple key-based string lookup in the main process that maps dialog messages to the appropriate locale 3. Fall back to English if the locale is not available Alternatively, if the dialogs can be moved from native `dialog.showMessageBox()` to Vue-based custom dialogs in the renderer process, they would automatically use the existing vue-i18n locale system. ### Potential workflow 1. User selects a language in settings (or uses system default) 2. User clicks Install 3. If an error occurs during installation (e.g., Python environment setup fails), the error dialog appears in the user's selected language instead of English 4. The same applies to all confirmation prompts during the installation flow ### Impact Level High (Major improvement) ### Alternatives Considered - Keeping the current behavior and only translating the in-UI progress text (which already uses vue-i18n). However, the native error dialogs are the most critical during installation since they often appear when something goes wrong, and users need to understand the error to resolve it. - Documenting the English error messages in a FAQ. This would be less effective since users encounter the error before they can search for help. --- **Version:** ComfyUI Desktop v0.8.36 (latest release)

bsakaguchi

2026-10-31 22:14:02 +00:00

closed this issue
added the
enhancement
label

bsakaguchi commented

2026-10-31 22:14:03 +00:00

Author

Owner

@ghost commented on GitHub (May 5, 2026):

Closing this and resubmitting via the proper feature request template.

@ghost commented on GitHub (May 5, 2026): Closing this and resubmitting via the proper feature request template.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#521

No description provided.

Rows
Columns