[PR #10] [MERGED] Reconcile Actions #552

Closed
opened 2026-10-31 22:14:48 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/10
Author: @KenCorma
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/4/2024
Merged by: @KenCorma

Base: main ← Head: prod-reconcile-actions


📝 Commits (4)

📊 Changes

9 files changed (+90 additions, -47 deletions)

View changed files

📝 .github/actions/build/macos/comfy/action.yml (+11 -11)
➖ .github/actions/build/macos/notorize/action.yml (+0 -0)
➕ .github/actions/build/macos/signing/action.yml (+24 -0)
📝 .github/actions/build/windows/app/action.yml (+2 -2)
📝 .github/workflows/debug_macos.yml (+23 -2)
📝 .github/workflows/publish_macos.yml (+8 -14)
📝 .github/workflows/publish_windows.yml (+1 -1)
📝 forge.config.ts (+19 -17)
📝 scripts/shim.sh (+2 -0)

📄 Description

Been making some changes to actions on my branches so combine everything.

This may cause some conflicts with @telamonian 's branch but it's mostly just syntax and moving things around. For example I have changed the directories that are moved in build/windows/app/action so that the current main branch will build. However I know that these lines will be changed further after you finish your work.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/10 **Author:** [@KenCorma](https://github.com/KenCorma) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@KenCorma](https://github.com/KenCorma) **Base:** `main` ← **Head:** `prod-reconcile-actions` --- ### 📝 Commits (4) - [`6f58992`](https://github.com/Comfy-Org/desktop/commit/6f589929e7e0bf8ab90581a2f93f48ba79803bdd) Reconfigured debug and publish - [`06245c5`](https://github.com/Comfy-Org/desktop/commit/06245c5f0d42f4a784daf066d20e15c06b124d42) Fixed Syntax - [`91ca515`](https://github.com/Comfy-Org/desktop/commit/91ca515b417c0a5f39acc6eeecc5f7dcbc40de2c) Did not have the sha var set - [`76ea1c2`](https://github.com/Comfy-Org/desktop/commit/76ea1c2dd1b2ac93f22fd47a0746373321fd5d9b) Change this just so it builds ### 📊 Changes **9 files changed** (+90 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/macos/comfy/action.yml` (+11 -11) ➖ `.github/actions/build/macos/notorize/action.yml` (+0 -0) ➕ `.github/actions/build/macos/signing/action.yml` (+24 -0) 📝 `.github/actions/build/windows/app/action.yml` (+2 -2) 📝 `.github/workflows/debug_macos.yml` (+23 -2) 📝 `.github/workflows/publish_macos.yml` (+8 -14) 📝 `.github/workflows/publish_windows.yml` (+1 -1) 📝 `forge.config.ts` (+19 -17) 📝 `scripts/shim.sh` (+2 -0) </details> ### 📄 Description Been making some changes to actions on my branches so combine everything. This may cause some conflicts with @telamonian 's branch but it's mostly just syntax and moving things around. For example I have changed the directories that are moved in build/windows/app/action so that the current main branch will build. However I know that these lines will be changed further after you finish your work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:14:48 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#552
No description provided.