[PR #47] [MERGED] Queue progress update messages until Renderer is ready. #577

Closed
opened 2026-10-31 22:15:01 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/47
Author: @robinjhuang
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/23/2024
Merged by: @robinjhuang

Base: main ← Head: rh-queuemessages


📝 Commits (2)

  • 1e902d8 Queue progress update messages until Renderer is ready.
  • cf6e988 Lint.

📊 Changes

4 files changed (+41 additions, -5 deletions)

View changed files

📝 src/constants.ts (+1 -0)
📝 src/main.ts (+28 -5)
📝 src/preload.ts (+4 -0)
📝 src/renderer/screens/ProgressOverlay.tsx (+8 -0)

📄 Description

Sometimes if an error is thrown too quickly, the IPC renderer is not ready to receive the message and the message gets lost.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/47 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/23/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-queuemessages` --- ### 📝 Commits (2) - [`1e902d8`](https://github.com/Comfy-Org/desktop/commit/1e902d8549af1950d8ab32f202083414d4679078) Queue progress update messages until Renderer is ready. - [`cf6e988`](https://github.com/Comfy-Org/desktop/commit/cf6e988b5a1212a39d6933f5051c14692d696994) Lint. ### 📊 Changes **4 files changed** (+41 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+1 -0) 📝 `src/main.ts` (+28 -5) 📝 `src/preload.ts` (+4 -0) 📝 `src/renderer/screens/ProgressOverlay.tsx` (+8 -0) </details> ### 📄 Description Sometimes if an error is thrown too quickly, the IPC renderer is not ready to receive the message and the message gets lost. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:15:01 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#577
No description provided.