mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[PR #51] [MERGED] Unzip and Sign needed files from python.tar #579
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#579
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Comfy-Org/desktop/pull/51
Author: @KenCorma
Created: 9/24/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @robinjhuang
Base:
main← Head:dev-kendal-mac📝 Commits (1)
47cafdasign these files📊 Changes
3 files changed (+27 additions, -24 deletions)
View changed files
📝
.github/actions/build/macos/comfy/action.yml(+22 -2)➖
.github/actions/build/macos/signwheel/action.yml(+0 -20)📝
.github/workflows/publish_macos.yml(+5 -2)📄 Description
Now in the comfy action, unzip the python tar file and sign the files that apple yells about.
You can add files to line33
You will know what files in the python.tar that are needed to be signed since Apple will tell you when they reject the notarization.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.