[PR #60] [MERGED] Fix Debug Mac bug #586

New issue

Closed

opened 2026-10-31 22:15:05 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/60
Author: @KenCorma
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @KenCorma

Base: main ← Head: bug-kendal-mac

📝 Commits (2)

286fe71 only unzip and sign if sign and pub true
f37acf5 format

📊 Changes

2 files changed (+17 additions, -12 deletions)

View changed files

📝 .github/actions/build/macos/comfy/action.yml (+15 -12)
📝 .github/workflows/publish_macos.yml (+2 -0)

📄 Description

I didn't check if we were in publish mode so the signing will fail. Added an if condition to that step.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/60 **Author:** [@KenCorma](https://github.com/KenCorma) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@KenCorma](https://github.com/KenCorma) **Base:** `main` ← **Head:** `bug-kendal-mac` --- ### 📝 Commits (2) - [`286fe71`](https://github.com/Comfy-Org/desktop/commit/286fe71c5e2eef788d55e37f22f6709ed8d1379b) only unzip and sign if sign and pub true - [`f37acf5`](https://github.com/Comfy-Org/desktop/commit/f37acf55feea72e865525b8b91d25d0dc45e03c8) format ### 📊 Changes **2 files changed** (+17 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/macos/comfy/action.yml` (+15 -12) 📝 `.github/workflows/publish_macos.yml` (+2 -0) </details> ### 📄 Description I didn't check if we were in publish mode so the signing will fail. Added an if condition to that step. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:05 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#586

No description provided.

Rows
Columns