[PR #117] [MERGED] Refactor python env setup #622

New issue

Closed

opened 2026-10-31 22:15:21 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:21 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/117
Author: @huchenlei
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @huchenlei

Base: main ← Head: refactor_python_install

📝 Commits (3)

408e007 Refactor python env setup
b60cbb5 nit
adc9276 nit

📊 Changes

3 files changed (+139 additions, -79 deletions)

View changed files

📝 src/main.ts (+5 -79)
➕ src/pythonEnvironment.ts (+124 -0)
➕ src/utils.ts (+10 -0)

📄 Description

This PR convert large function setupPythonEnvironment into a class.

All original logic from the original function is preserved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/117 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `refactor_python_install` --- ### 📝 Commits (3) - [`408e007`](https://github.com/Comfy-Org/desktop/commit/408e007148bd8e7971f5e668f7f7bcd537df9d4d) Refactor python env setup - [`b60cbb5`](https://github.com/Comfy-Org/desktop/commit/b60cbb50170a9b0e205c2785a21950ca57b0f5dc) nit - [`adc9276`](https://github.com/Comfy-Org/desktop/commit/adc9276934f89fc9f7a8dfc932847ace03d40652) nit ### 📊 Changes **3 files changed** (+139 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `src/main.ts` (+5 -79) ➕ `src/pythonEnvironment.ts` (+124 -0) ➕ `src/utils.ts` (+10 -0) </details> ### 📄 Description This PR convert large function `setupPythonEnvironment` into a class. All original logic from the original function is preserved. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:21 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:26 +00:00

[PR #622] [MERGED] [Cleanup] Remove COMFYUI_CPU_ONLY env var #972

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#622

No description provided.

Rows
Columns