[PR #135] [CLOSED] Draft: Use uv to install python instead. #634

New issue

Closed

opened 2026-10-31 22:15:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/135
Author: @robinjhuang
Created: 10/28/2024
Status: ❌ Closed

Base: main ← Head: rh-uv

📝 Commits (10+)

ab954e6 switch some to spawnSync
3b4521d change to py
6ac0bbb move make nvidia to js
b6b6e2f split comfy install and rehydrate
c0d3ef1 try this but only on github
f55869f try this
51764fa set path
6172fd9 diff path
1a65558 try setx
68cc7df back to path

📊 Changes

19 files changed (+891 additions, -175 deletions)

View changed files

📝 .github/actions/build/windows/todesktop/action.yml (+0 -2)
📝 .github/workflows/debug_macos.yml (+1 -0)
➕ .husky/pre-commit (+1 -0)
➕ assets/uv/uv (+0 -0)
➕ assets/uv/uvx (+0 -0)
📝 package.json (+10 -1)
📝 scripts/signPython.sh (+24 -14)
📝 scripts/todesktop/afterPack.js (+84 -1)
📝 scripts/todesktop/beforeInstall.js (+3 -5)
📝 scripts/todesktop/postInstall.js (+23 -9)
📝 src/constants.ts (+1 -0)
📝 src/main.ts (+39 -37)
📝 src/preload.ts (+4 -0)
📝 src/pythonEnvironment.ts (+24 -0)
📝 src/renderer/components/ComfyUIContainer.tsx (+7 -1)
📝 src/tray.ts (+34 -1)
➕ src/virtualEnvironment.ts (+181 -0)
📝 todesktop.json (+1 -1)
📝 yarn.lock (+454 -103)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/135 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 10/28/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rh-uv` --- ### 📝 Commits (10+) - [`ab954e6`](https://github.com/Comfy-Org/desktop/commit/ab954e6280c2bdc60ff16dfed4be496a6e199fe5) switch some to spawnSync - [`3b4521d`](https://github.com/Comfy-Org/desktop/commit/3b4521d3fa59f7e6c9bce810b175ca8c0e198d44) change to py - [`6ac0bbb`](https://github.com/Comfy-Org/desktop/commit/6ac0bbbf923e107a67bc528061e6ed8182e9126e) move make nvidia to js - [`b6b6e2f`](https://github.com/Comfy-Org/desktop/commit/b6b6e2f91dca446dc12cee1a9e251894472274c8) split comfy install and rehydrate - [`c0d3ef1`](https://github.com/Comfy-Org/desktop/commit/c0d3ef13b57157cde901ddcbbd1262e43f0ee1ee) try this but only on github - [`f55869f`](https://github.com/Comfy-Org/desktop/commit/f55869fc648b50a64a8bbfdf065c1831ebe5d6eb) try this - [`51764fa`](https://github.com/Comfy-Org/desktop/commit/51764faf2a5638e23c131fa07f0eecf1a5bf67f5) set path - [`6172fd9`](https://github.com/Comfy-Org/desktop/commit/6172fd92fd360257f04553cc1fb416c4f264e647) diff path - [`1a65558`](https://github.com/Comfy-Org/desktop/commit/1a655584faa6c2733db964485c282df509cc83bf) try setx - [`68cc7df`](https://github.com/Comfy-Org/desktop/commit/68cc7df371fb30697ae9ea3c92f0d6fa151399ef) back to path ### 📊 Changes **19 files changed** (+891 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/windows/todesktop/action.yml` (+0 -2) 📝 `.github/workflows/debug_macos.yml` (+1 -0) ➕ `.husky/pre-commit` (+1 -0) ➕ `assets/uv/uv` (+0 -0) ➕ `assets/uv/uvx` (+0 -0) 📝 `package.json` (+10 -1) 📝 `scripts/signPython.sh` (+24 -14) 📝 `scripts/todesktop/afterPack.js` (+84 -1) 📝 `scripts/todesktop/beforeInstall.js` (+3 -5) 📝 `scripts/todesktop/postInstall.js` (+23 -9) 📝 `src/constants.ts` (+1 -0) 📝 `src/main.ts` (+39 -37) 📝 `src/preload.ts` (+4 -0) 📝 `src/pythonEnvironment.ts` (+24 -0) 📝 `src/renderer/components/ComfyUIContainer.tsx` (+7 -1) 📝 `src/tray.ts` (+34 -1) ➕ `src/virtualEnvironment.ts` (+181 -0) 📝 `todesktop.json` (+1 -1) 📝 `yarn.lock` (+454 -103) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:29 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:30 +00:00

[PR #634] [MERGED] [chore] Use upload-artifact v4 #980

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#634

No description provided.

Rows
Columns