[PR #139] [MERGED] Yarn Dev/Make Fixes, Local ComfyCLI Fix, Todesktop security adjustments #635

New issue

Closed

opened 2026-10-31 22:15:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/139
Author: @KenCorma
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @KenCorma

Base: main ← Head: dev-kendal-fixes

📝 Commits (10+)

275921f Just upload these files
c5deec7 Fixes #124
c27b724 Only init todesktop when built with CI. #129
f78a69d Made a mistake
4863cd3 Fixed resource folder
618369c Closes #129
818be95 Yarn Make now makes ComfyCLI on mac
2a873ab Fixed up windows make and has nvidia switch
2253a7d Removed rehydration from mac
7819c4e Merge remote-tracking branch 'origin/main' into dev-kendal-fixes

📊 Changes

15 files changed (+53 additions, -43 deletions)

View changed files

📝 .github/workflows/publish_all.yml (+0 -1)
➖ assets/output/bin/python3.12 (+0 -0)
➖ assets/output/bin/uv (+0 -0)
➖ assets/output/bin/uvx (+0 -0)
➖ assets/output/lib/libpython3.12.dylib (+0 -0)
➖ assets/output/lib/python3.12/lib-dynload/_crypt.cpython-312-darwin.so (+0 -0)
📝 builder-debug.config.ts (+3 -3)
📝 forge.env.d.ts (+1 -1)
📝 package.json (+1 -0)
📝 scripts/launchdev.js (+0 -2)
➕ scripts/preMake.js (+39 -0)
➖ scripts/signPython.sh (+0 -29)
📝 scripts/todesktop/postInstall.js (+5 -5)
📝 src/main.ts (+3 -2)
📝 vite.main.config.ts (+1 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/139 **Author:** [@KenCorma](https://github.com/KenCorma) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@KenCorma](https://github.com/KenCorma) **Base:** `main` ← **Head:** `dev-kendal-fixes` --- ### 📝 Commits (10+) - [`275921f`](https://github.com/Comfy-Org/desktop/commit/275921fe6ff82faf60fc2db35298803077ea2ae0) Just upload these files - [`c5deec7`](https://github.com/Comfy-Org/desktop/commit/c5deec78230e99567eac91e1253d775de9b7b8b9) Fixes #124 - [`c27b724`](https://github.com/Comfy-Org/desktop/commit/c27b724ab9991d0685b414d5d6390d1254dc02ec) Only init todesktop when built with CI. #129 - [`f78a69d`](https://github.com/Comfy-Org/desktop/commit/f78a69d2d53f4b9d8e267d8b09008df858fa72b0) Made a mistake - [`4863cd3`](https://github.com/Comfy-Org/desktop/commit/4863cd382278227b782d74e661e3e439e8ce6da5) Fixed resource folder - [`618369c`](https://github.com/Comfy-Org/desktop/commit/618369caed3e54ae990d79f9252ef561c2b3d991) Closes #129 - [`818be95`](https://github.com/Comfy-Org/desktop/commit/818be9541f75f097a31860cf1637a94617c75521) Yarn Make now makes ComfyCLI on mac - [`2a873ab`](https://github.com/Comfy-Org/desktop/commit/2a873ab9445eadbb46971836b2c6d53ff79f837a) Fixed up windows make and has nvidia switch - [`2253a7d`](https://github.com/Comfy-Org/desktop/commit/2253a7d1ac4dfe66bcc5af832fbbd666189f8b5c) Removed rehydration from mac - [`7819c4e`](https://github.com/Comfy-Org/desktop/commit/7819c4ef959e6ec156364b492fa422e1bd016323) Merge remote-tracking branch 'origin/main' into dev-kendal-fixes ### 📊 Changes **15 files changed** (+53 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/publish_all.yml` (+0 -1) ➖ `assets/output/bin/python3.12` (+0 -0) ➖ `assets/output/bin/uv` (+0 -0) ➖ `assets/output/bin/uvx` (+0 -0) ➖ `assets/output/lib/libpython3.12.dylib` (+0 -0) ➖ `assets/output/lib/python3.12/lib-dynload/_crypt.cpython-312-darwin.so` (+0 -0) 📝 `builder-debug.config.ts` (+3 -3) 📝 `forge.env.d.ts` (+1 -1) 📝 `package.json` (+1 -0) 📝 `scripts/launchdev.js` (+0 -2) ➕ `scripts/preMake.js` (+39 -0) ➖ `scripts/signPython.sh` (+0 -29) 📝 `scripts/todesktop/postInstall.js` (+5 -5) 📝 `src/main.ts` (+3 -2) 📝 `vite.main.config.ts` (+1 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:29 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#635

No description provided.

Rows
Columns