[PR #144] [MERGED] Fix presubmit typecheck hook #639

New issue

Closed

opened 2026-10-31 22:15:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/144
Author: @huchenlei
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @huchenlei

Base: main ← Head: fix_presubmit

📝 Commits (1)

ee0a09e Fix presubmit typecheck hook

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 .husky/pre-commit (+1 -0)
📝 package.json (+1 -2)

📄 Description

"lint-staged" cannot correctly handle the range of typecheck. Adding the typecheck to pre-commit hook directly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/144 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_presubmit` --- ### 📝 Commits (1) - [`ee0a09e`](https://github.com/Comfy-Org/desktop/commit/ee0a09ee487228a9f9fbd5d9f40d055e263b7225) Fix presubmit typecheck hook ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.husky/pre-commit` (+1 -0) 📝 `package.json` (+1 -2) </details> ### 📄 Description "lint-staged" cannot correctly handle the range of typecheck. Adding the typecheck to pre-commit hook directly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:31 +00:00

[PR #639] [MERGED] nit: Fix format #982

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#639

No description provided.

Rows
Columns