[PR #177] [MERGED] [Refactor] Move registerIpcHandlers call out of getInstance #664

New issue

Closed

opened 2026-10-31 22:15:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/177
Author: @huchenlei
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @huchenlei

Base: main ← Head: ipc_move

📝 Commits (1)

a779cbc [Refactor] Move registerIpcHandlers call out of getInstance

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 src/main.ts (+2 -0)
📝 src/models/DownloadManager.ts (+1 -2)

📄 Description

registerIpcHandlers is an important lifecycle event that should not depend on when DownloadManager instance is first accessed.

Moving the call to main will give us explicit understanding of the lifecycle.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/177 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `ipc_move` --- ### 📝 Commits (1) - [`a779cbc`](https://github.com/Comfy-Org/desktop/commit/a779cbcefecacac48c948290d92e4d6e96dee14a) [Refactor] Move registerIpcHandlers call out of getInstance ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/main.ts` (+2 -0) 📝 `src/models/DownloadManager.ts` (+1 -2) </details> ### 📄 Description `registerIpcHandlers` is an important lifecycle event that should not depend on when `DownloadManager` instance is first accessed. Moving the call to main will give us explicit understanding of the lifecycle. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:47 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:41 +00:00

[PR #664] [CLOSED] 0.4.11(types) #1002

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#664

No description provided.

Rows
Columns