[PR #200] [MERGED] Standardize progress status #681

New issue

Closed

opened 2026-10-31 22:15:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/200
Author: @huchenlei
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @huchenlei

Base: main ← Head: progress_status

📝 Commits (1)

7fa6fc1 Standardize progress status

📊 Changes

5 files changed (+53 additions, -32 deletions)

View changed files

📝 src/constants.ts (+36 -3)
📝 src/main.ts (+8 -14)
📝 src/preload.ts (+2 -2)
📝 src/renderer/index.tsx (+3 -9)
📝 src/renderer/screens/ProgressOverlay.tsx (+4 -4)

📄 Description

This PR standardize the progress status as an Enum for better downstream consumption.

export enum ProgressStatus {
  /**
   * Initial state, after the app has started.
   */
  INITIAL_STATE = 'initial-state',
  /**
   * Setting up Python Environment.
   */
  PYTHON_SETUP = 'python-setup',
  /**
   * Starting ComfyUI server.
   */
  STARTING_SERVER = 'starting-server',
  /**
   * Ending state.
   * The ComfyUI server successfully started. ComfyUI loaded into the main window.
   */
  READY = 'ready',
  /**
   * Ending state. General error state.
   */
  ERROR = 'error',
  /**
   * Error state. Installation path does not exist.
   */
  ERROR_INSTALL_PATH = 'error-install-path',
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/200 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/7/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `progress_status` --- ### 📝 Commits (1) - [`7fa6fc1`](https://github.com/Comfy-Org/desktop/commit/7fa6fc1e65a065f4658744b956c7418486f0dd45) Standardize progress status ### 📊 Changes **5 files changed** (+53 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+36 -3) 📝 `src/main.ts` (+8 -14) 📝 `src/preload.ts` (+2 -2) 📝 `src/renderer/index.tsx` (+3 -9) 📝 `src/renderer/screens/ProgressOverlay.tsx` (+4 -4) </details> ### 📄 Description This PR standardize the progress status as an Enum for better downstream consumption. ```ts export enum ProgressStatus { /** * Initial state, after the app has started. */ INITIAL_STATE = 'initial-state', /** * Setting up Python Environment. */ PYTHON_SETUP = 'python-setup', /** * Starting ComfyUI server. */ STARTING_SERVER = 'starting-server', /** * Ending state. * The ComfyUI server successfully started. ComfyUI loaded into the main window. */ READY = 'ready', /** * Ending state. General error state. */ ERROR = 'error', /** * Error state. Installation path does not exist. */ ERROR_INSTALL_PATH = 'error-install-path', } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:56 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:49 +00:00

[PR #681] [MERGED] Update metrics section of readme. #1018

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#681

No description provided.

Rows
Columns