[PR #207] [MERGED] Refactor BrowserWindow into AppWindow #684

New issue

Closed

opened 2026-10-31 22:15:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/207
Author: @robinjhuang
Created: 11/8/2024
Status: ✅ Merged
Merged: 11/8/2024
Merged by: @robinjhuang

Base: main ← Head: rh-appwindow

📝 Commits (8)

d704530 Refactor browser window into AppWindow.
9661efb Refactor.
cd75ec3 Check renderer status.
48ef37c Refactor.
97d6a94 Remove null checks.
80097c0 Use personal access token.
85683b7 Rename mainWindow -> appWindow.
8e6945d Update.

📊 Changes

5 files changed (+202 additions, -185 deletions)

View changed files

📝 .github/workflows/debug_macos.yml (+3 -0)
➕ src/main-process/appWindow.ts (+158 -0)
📝 src/main.ts (+30 -177)
📝 src/models/DownloadManager.ts (+8 -6)
📝 src/tray.ts (+3 -2)

📄 Description

Fixed some potential bugs as well:

Wait for renderer to send ready event before sending message to renderer (previously part of the implementation checked the "is loading" event)

Closes #145

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/207 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/8/2024 **Status:** ✅ Merged **Merged:** 11/8/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-appwindow` --- ### 📝 Commits (8) - [`d704530`](https://github.com/Comfy-Org/desktop/commit/d704530a73b4336bac71210fa1615c7f4dbf0d03) Refactor browser window into AppWindow. - [`9661efb`](https://github.com/Comfy-Org/desktop/commit/9661efb9b36bd328fc5ced339c404073aa28678f) Refactor. - [`cd75ec3`](https://github.com/Comfy-Org/desktop/commit/cd75ec3a21fcc92bb9164bfd008ebabcd43e3705) Check renderer status. - [`48ef37c`](https://github.com/Comfy-Org/desktop/commit/48ef37c19ecf88ee2bd7cc7ef94725b679b7f180) Refactor. - [`97d6a94`](https://github.com/Comfy-Org/desktop/commit/97d6a944a48fe02420a772a65d07808cad05fe62) Remove null checks. - [`80097c0`](https://github.com/Comfy-Org/desktop/commit/80097c0f4399cc98ccd77369031e8cf0bb3226f7) Use personal access token. - [`85683b7`](https://github.com/Comfy-Org/desktop/commit/85683b71f13f6fbba0b3fd528001e782d9b1915e) Rename mainWindow -> appWindow. - [`8e6945d`](https://github.com/Comfy-Org/desktop/commit/8e6945d87f44bcdf9451328da528b99687efcaff) Update. ### 📊 Changes **5 files changed** (+202 additions, -185 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/debug_macos.yml` (+3 -0) ➕ `src/main-process/appWindow.ts` (+158 -0) 📝 `src/main.ts` (+30 -177) 📝 `src/models/DownloadManager.ts` (+8 -6) 📝 `src/tray.ts` (+3 -2) </details> ### 📄 Description Fixed some potential bugs as well: - Wait for renderer to send ready event before sending message to renderer (previously part of the implementation checked the "is loading" event) Closes [#145 ](https://github.com/Comfy-Org/electron/issues/204) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:59 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#684

No description provided.

Rows
Columns