[PR #248] [MERGED] Install Python using uv. #723

New issue

Closed

opened 2026-10-31 22:16:18 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:18 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/248
Author: @robinjhuang
Created: 11/14/2024
Status: ✅ Merged
Merged: 11/14/2024
Merged by: @robinjhuang

Base: main ← Head: rh-uv3

📝 Commits (10+)

7abc694 Use uv to install python.
567bef2 Use resource path for mac.
908797d download UV on github action and build time pick platform
1e77024 async command
c9720b5 Delete some items on windows
add68b4 cleaning up old code
0dda8d3 Local UV and CI uses UV ver in Package.json
f0bb02c Removed some items from virtualEnviroment
7147ea7 Remove Python stuff from CI build
98c3669 Filter via string endsWith

📊 Changes

16 files changed (+469 additions, -339 deletions)

View changed files

📝 .github/actions/build/windows/todesktop/action.yml (+2 -0)
📝 .gitignore (+3 -0)
📝 README.md (+6 -8)
📝 builder-debug.config.ts (+2 -1)
📝 package.json (+5 -2)
➖ scripts/checkAssetsMacos.sh (+0 -10)
➕ scripts/downloadUV.js (+83 -0)
📝 scripts/makeComfy.js (+2 -5)
📝 scripts/todesktop/afterPack.js (+21 -4)
📝 scripts/todesktop/postInstall.js (+35 -21)
📝 src/main.ts (+43 -105)
➖ src/pythonEnvironment.ts (+0 -166)
📝 src/tray.ts (+1 -0)
➕ src/virtualEnvironment.ts (+242 -0)
📝 todesktop.json (+14 -9)
📝 vite.main.config.ts (+10 -8)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/248 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-uv3` --- ### 📝 Commits (10+) - [`7abc694`](https://github.com/Comfy-Org/desktop/commit/7abc69436f8deaa6ef88cbddf4f8be2cd9274027) Use uv to install python. - [`567bef2`](https://github.com/Comfy-Org/desktop/commit/567bef20bca7a63a036bba18f3df321981c5f87d) Use resource path for mac. - [`908797d`](https://github.com/Comfy-Org/desktop/commit/908797d60389a9191c64e96f6743ecf831f254ba) download UV on github action and build time pick platform - [`1e77024`](https://github.com/Comfy-Org/desktop/commit/1e77024728f77db9e741bd11f00c17c2adbf94c7) async command - [`c9720b5`](https://github.com/Comfy-Org/desktop/commit/c9720b5ff6bb57bc8bb0f5a015120c31b36def99) Delete some items on windows - [`add68b4`](https://github.com/Comfy-Org/desktop/commit/add68b444f6234e1751bcd7e707b32b2413ebed2) cleaning up old code - [`0dda8d3`](https://github.com/Comfy-Org/desktop/commit/0dda8d34b8a959bd19117c8e2a12c458ac957529) Local UV and CI uses UV ver in Package.json - [`f0bb02c`](https://github.com/Comfy-Org/desktop/commit/f0bb02c13886d13357a298427a277eeb8a9c41fb) Removed some items from virtualEnviroment - [`7147ea7`](https://github.com/Comfy-Org/desktop/commit/7147ea7d32f63b56c732c70bd28d1b9e60399b02) Remove Python stuff from CI build - [`98c3669`](https://github.com/Comfy-Org/desktop/commit/98c366935807800f0ddb1f17be411c68204800c1) Filter via string endsWith ### 📊 Changes **16 files changed** (+469 additions, -339 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/windows/todesktop/action.yml` (+2 -0) 📝 `.gitignore` (+3 -0) 📝 `README.md` (+6 -8) 📝 `builder-debug.config.ts` (+2 -1) 📝 `package.json` (+5 -2) ➖ `scripts/checkAssetsMacos.sh` (+0 -10) ➕ `scripts/downloadUV.js` (+83 -0) 📝 `scripts/makeComfy.js` (+2 -5) 📝 `scripts/todesktop/afterPack.js` (+21 -4) 📝 `scripts/todesktop/postInstall.js` (+35 -21) 📝 `src/main.ts` (+43 -105) ➖ `src/pythonEnvironment.ts` (+0 -166) 📝 `src/tray.ts` (+1 -0) ➕ `src/virtualEnvironment.ts` (+242 -0) 📝 `todesktop.json` (+14 -9) 📝 `vite.main.config.ts` (+10 -8) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:18 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:19:04 +00:00

[PR #723] [MERGED] [Test] Fix path-reliant tests on Windows #1047

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#723

No description provided.

Rows
Columns