[PR #256] [MERGED] Disallow selecting existing ComfyUI dir as install path #731

New issue

Closed

opened 2026-10-31 22:16:23 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:23 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/256
Author: @huchenlei
Created: 11/15/2024
Status: ✅ Merged
Merged: 11/15/2024
Merged by: @huchenlei

Base: main ← Head: ban_existing_dir

📝 Commits (3)

9d2c44a Disallow selecting existing ComfyUI dir as install path
93e9b8d Fix tests
c30507f nit

📊 Changes

4 files changed (+21 additions, -33 deletions)

View changed files

📝 src/config/comfyConfigManager.ts (+3 -8)
📝 src/handlers/pathHandlers.ts (+11 -4)
📝 src/main.ts (+2 -1)
📝 tests/unit/comfyConfigManager.test.ts (+5 -20)

📄 Description

This PR disallows user select existing ComfyUI directory as install path. Now we always use <selected_dir>/ComfyUI as install location.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/256 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/15/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `ban_existing_dir` --- ### 📝 Commits (3) - [`9d2c44a`](https://github.com/Comfy-Org/desktop/commit/9d2c44af4da9ea6a89aa51131ec50e1fc381872e) Disallow selecting existing ComfyUI dir as install path - [`93e9b8d`](https://github.com/Comfy-Org/desktop/commit/93e9b8d533b411e0362a5065f1d8bf3092277b1d) Fix tests - [`c30507f`](https://github.com/Comfy-Org/desktop/commit/c30507f2fbe2065fc9d4baccfd589ea2185437e1) nit ### 📊 Changes **4 files changed** (+21 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfyConfigManager.ts` (+3 -8) 📝 `src/handlers/pathHandlers.ts` (+11 -4) 📝 `src/main.ts` (+2 -1) 📝 `tests/unit/comfyConfigManager.test.ts` (+5 -20) </details> ### 📄 Description This PR disallows user select existing ComfyUI directory as install path. Now we always use `<selected_dir>/ComfyUI` as install location. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:23 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#731

No description provided.

Rows
Columns