[PR #294] [MERGED] [Refactor] Extract install logic as InstallWizard class #765

New issue

Closed

opened 2026-10-31 22:16:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/294
Author: @huchenlei
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @huchenlei

Base: main ← Head: refactor_install

📝 Commits (2)

acb38de [Refactor] Extract install logic as InstallWizard class
62cef60 Move tests

📊 Changes

5 files changed (+146 additions, -97 deletions)

View changed files

📝 src/config/comfyServerConfig.ts (+1 -33)
➕ src/install/installWizard.ts (+88 -0)
📝 src/main-process/comfyDesktopApp.ts (+5 -29)
📝 tests/unit/comfyServerConfig.test.ts (+0 -35)
➕ tests/unit/installWizard.test.ts (+52 -0)

📄 Description

This PR extract installation related logic as InstallWizard class that operates on InstallOptions data.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/294 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `refactor_install` --- ### 📝 Commits (2) - [`acb38de`](https://github.com/Comfy-Org/desktop/commit/acb38decdbb1dbf1f22bd1647a2e2584a27eaa83) [Refactor] Extract install logic as InstallWizard class - [`62cef60`](https://github.com/Comfy-Org/desktop/commit/62cef6018975bfc8cd15e6ecbe1ef711459256e3) Move tests ### 📊 Changes **5 files changed** (+146 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfyServerConfig.ts` (+1 -33) ➕ `src/install/installWizard.ts` (+88 -0) 📝 `src/main-process/comfyDesktopApp.ts` (+5 -29) 📝 `tests/unit/comfyServerConfig.test.ts` (+0 -35) ➕ `tests/unit/installWizard.test.ts` (+52 -0) </details> ### 📄 Description This PR extract installation related logic as `InstallWizard` class that operates on `InstallOptions` data. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:44 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:19:20 +00:00

[PR #766] [MERGED] Add maintenance task logging #1080

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#765

No description provided.

Rows
Columns