[PR #363] [MERGED] Installer window #820

Closed
opened 2026-10-31 22:17:12 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/363
Author: @webfiltered
Created: 11/26/2024
Status: ✅ Merged
Merged: 12/9/2024
Merged by: @robinjhuang

Base: main ← Head: installer-window


📝 Commits (1)

  • 41d1395 Add focused installation experience

📊 Changes

2 files changed (+13 additions, -5 deletions)

View changed files

📝 src/main-process/appWindow.ts (+12 -5)
📝 src/main-process/comfyDesktopApp.ts (+1 -0)

📄 Description

This simply has different window sizes for the install process:

  • Window starts centred on screen, 1024 x 768
  • User runs through the install process
  • Window is maximised as the final step of installation
  • Also increases the window min size to 640 x 640
  • No effect if the user has moved or altered the window before in any way

32:9 - New default window size / position

image

16:9 - Same window size, half screen res

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/363 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `installer-window` --- ### 📝 Commits (1) - [`41d1395`](https://github.com/Comfy-Org/desktop/commit/41d1395f35d269a1b252fd496114fb4b020e7f0e) Add focused installation experience ### 📊 Changes **2 files changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+12 -5) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -0) </details> ### 📄 Description - Requires #362 This simply has different window sizes for the install process: - Window starts centred on screen, 1024 x 768 - User runs through the install process - Window is maximised as the final step of installation - Also increases the window min size to 640 x 640 - No effect if the user has moved or altered the window before in any way #### 32:9 - New default window size / position ![image](https://github.com/user-attachments/assets/f1d89c23-3163-4be9-92d2-abcf8bfd68f7) #### 16:9 - Same window size, half screen res ![image](https://github.com/user-attachments/assets/dd3078d2-4635-4527-b43f-159f1c5c679e) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:17:12 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#820
No description provided.