[PR #446] [MERGED] Reland #362 - improved startup error handling #873

New issue

Closed

opened 2026-10-31 22:17:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/446
Author: @webfiltered
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @huchenlei

Base: main ← Head: settings-store-iii

📝 Commits (5)

d31de10 Reapply "Settings store (#362)" (#440)
12ae4be Allow user to see result of YAML config read
e257909 Fix cannot start app if invalid install state
86088b2 Detect YAML parse exceptions
810f504 Update test expectations

📊 Changes

9 files changed (+359 additions, -45 deletions)

View changed files

📝 scripts/resetInstall.js (+41 -13)
📝 src/config/comfyServerConfig.ts (+44 -13)
➕ src/install/installationValidator.ts (+60 -0)
📝 src/main-process/appWindow.ts (+4 -4)
📝 src/main-process/comfyDesktopApp.ts (+69 -8)
📝 src/main.ts (+16 -1)
➕ src/store/desktopConfig.ts (+104 -0)
📝 src/store/index.ts (+13 -1)
📝 tests/unit/comfyServerConfig.test.ts (+8 -5)

📄 Description

Allow user to see result of YAML config read

Nature of the failure is returned
Invalid values read are included if available
Retains inferred types

When the file exists but base_path is just invalid:

In this PR, it pretends the file doesn't exist and reinstalls
Should be connected to the UI path picker, once finalised

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/446 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `settings-store-iii` --- ### 📝 Commits (5) - [`d31de10`](https://github.com/Comfy-Org/desktop/commit/d31de10129192bab264406307aab588300edfe28) Reapply "Settings store (#362)" (#440) - [`12ae4be`](https://github.com/Comfy-Org/desktop/commit/12ae4be711ffc14c9e4fc0cbb22f7c41bbddb581) Allow user to see result of YAML config read - [`e257909`](https://github.com/Comfy-Org/desktop/commit/e257909dbcaa143a12e58fcbbdbb0c97d99cfd50) Fix cannot start app if invalid install state - [`86088b2`](https://github.com/Comfy-Org/desktop/commit/86088b22773ad6543f6cb12a7bb155af3a09c572) Detect YAML parse exceptions - [`810f504`](https://github.com/Comfy-Org/desktop/commit/810f504445296a280a21f09f46e5ab055fc520f8) Update test expectations ### 📊 Changes **9 files changed** (+359 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `scripts/resetInstall.js` (+41 -13) 📝 `src/config/comfyServerConfig.ts` (+44 -13) ➕ `src/install/installationValidator.ts` (+60 -0) 📝 `src/main-process/appWindow.ts` (+4 -4) 📝 `src/main-process/comfyDesktopApp.ts` (+69 -8) 📝 `src/main.ts` (+16 -1) ➕ `src/store/desktopConfig.ts` (+104 -0) 📝 `src/store/index.ts` (+13 -1) 📝 `tests/unit/comfyServerConfig.test.ts` (+8 -5) </details> ### 📄 Description Allow user to see result of YAML config read - Nature of the failure is returned - Invalid values read are included if available - Retains inferred types When the file exists but base_path is just invalid: - In this PR, it pretends the file doesn't exist and reinstalls - Should be connected to the UI path picker, once finalised --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:39 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#873

No description provided.

Rows
Columns